[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2] templates/linux_xen: Fix XSM entries generation
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v2] templates/linux_xen: Fix XSM entries generation |
Date: |
Thu, 14 Sep 2023 16:22:27 +0200 |
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Mon, Sep 11, 2023 at 02:43:45PM +0100, Anthony PERARD via Grub-devel wrote:
> It turns out that setting $xen_version in linux_entry_xsm() override
> $xen_version in the loop over $reverse_sorted_xen_list. This means
> that only one entry per Xen version is going to enable XSM, but all
> further entries are going to have "(XSM enabled)" in their titles
> without enabling XSM.
>
> When a "xenpolicy-$xen_version" file was found for the current
> $xen_version, it would overwrite $xen_version to add "(XSM enabled)"
> to the menu entry title. Once updated, the next call to
> linux_entry_xsm() would also have this modified $xen_version and would
> look for the file "xenpolicy-*(XSM enabled)" and fail.
>
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel