[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v9 18/22] cryptodisk: Fallback to passphrase
From: |
Gary Lin |
Subject: |
[PATCH v9 18/22] cryptodisk: Fallback to passphrase |
Date: |
Mon, 5 Feb 2024 15:39:51 +0800 |
From: Patrick Colp <patrick.colp@oracle.com>
If a protector is specified, but it fails to unlock the disk, fall back
to asking for the passphrase. However, an error was set indicating that
the protector(s) failed. Later code (e.g., LUKS code) fails as
`grub_errno` is now set. Print the existing errors out first, before
proceeding with the passphrase.
Signed-off-by: Patrick Colp <patrick.colp@oracle.com>
Signed-off-by: Gary Lin <glin@suse.com>
---
grub-core/disk/cryptodisk.c | 7 ++++++-
1 file changed, 6 insertions(+), 1 deletion(-)
diff --git a/grub-core/disk/cryptodisk.c b/grub-core/disk/cryptodisk.c
index 0ca1a5c4d..0dbf601c4 100644
--- a/grub-core/disk/cryptodisk.c
+++ b/grub-core/disk/cryptodisk.c
@@ -1191,11 +1191,16 @@ grub_cryptodisk_scan_device_real (const char *name,
source->name, source->partition != NULL ? "," : "",
part != NULL ? part : N_("UNKNOWN"), dev->uuid);
grub_free (part);
- goto error;
}
if (!cargs->key_len)
{
+ if (grub_errno)
+ {
+ grub_print_error ();
+ grub_errno = GRUB_ERR_NONE;
+ }
+
/* Get the passphrase from the user, if no key data. */
askpass = 1;
part = grub_partition_get_name (source->partition);
--
2.35.3
- [PATCH v9 08/22] key_protector: Add key protectors framework, (continued)
- [PATCH v9 08/22] key_protector: Add key protectors framework, Gary Lin, 2024/02/05
- [PATCH v9 09/22] tpm2: Add TPM Software Stack (TSS), Gary Lin, 2024/02/05
- [PATCH v9 11/22] cryptodisk: Support key protectors, Gary Lin, 2024/02/05
- [PATCH v9 10/22] key_protector: Add TPM2 Key Protector, Gary Lin, 2024/02/05
- [PATCH v9 12/22] util/grub-protect: Add new tool, Gary Lin, 2024/02/05
- [PATCH v9 13/22] tpm2: Add TPM2 types, structures, and command constants, Gary Lin, 2024/02/05
- [PATCH v9 14/22] tpm2: Add more marshal/unmarshal functions, Gary Lin, 2024/02/05
- [PATCH v9 15/22] tpm2: Implement more TPM2 commands, Gary Lin, 2024/02/05
- [PATCH v9 16/22] tpm2: Support authorized policy, Gary Lin, 2024/02/05
- [PATCH v9 17/22] tpm2: Implement NV index, Gary Lin, 2024/02/05
- [PATCH v9 18/22] cryptodisk: Fallback to passphrase,
Gary Lin <=
- [PATCH v9 19/22] cryptodisk: wipe out the cached keys from protectors, Gary Lin, 2024/02/05
- [PATCH v9 21/22] tpm2: Enable tpm2 module for grub-emu, Gary Lin, 2024/02/05
- [PATCH v9 20/22] diskfilter: look up cryptodisk devices first, Gary Lin, 2024/02/05
- [PATCH v9 22/22] tests: Add tpm2_test, Gary Lin, 2024/02/05
- Re: [PATCH v9 00/22] Automatic Disk Unlock with TPM2, Daniel Kiper, 2024/02/08