Re: Re: [PATCH] disk: Prioritize OS disk devices over memdisk and procfs

[Daniel Kiper]

On Mon, Mar 18, 2024 at 02:21:36PM +0800, Michael Chang wrote:
> On Fri, Mar 15, 2024 at 04:09:02PM +0100, Daniel Kiper wrote:
> > On Fri, Mar 15, 2024 at 05:00:28PM +0800, Michael Chang via Grub-devel 
> > wrote:
> > > Refine iteration to prioritize returning system disk devices over
> > > memdisk and procfs. This adjustment brings about a modest improvement in
> > > search efficiency, particularly during file or UUID-based
> > > searches for a root file system. Additionally, it helps mitigate
> > > potential collisions in file-based searches where memdisk may mistakenly
> > > take precedence over system disks.
> >
> > It seems to me you could do this without adding additional loops. If it
> > is not possible the change begs for comment.
>
> Thanks for review. The added loop for proc and memdisk in the final
> output is required for the `ls' to output list of all devices. I'll add
> this to the comment and send v2 patch.

I understand that. However, by adding two ifs and two variables or so
you would be able to avoid two additional loops. And I would really
prefer that...

Daniel