Re: bug #61620: Grub2 fails to detect LVM volumes with: error: disk `lvmid/*/*' not found

[Horst Prote]

On 26.04.2024, Glenn Washburn wrote:

> On Wed, 3 Apr 2024 10:23:59 +0200
> Horst Prote <prote@fmi.uni-stuttgart.de> wrote:
> 
> > Hi,
> > 
> > could the patch supplied in bug #61620
> > (https://savannah.gnu.org/bugs/?func=detailitem&item_id=61620) please be
> > reviewed and applied.  
> 
> Unfortunately, the issues tracker is mostly unused. Patches are
> exclusively reviewed on this list. It would be nice if patches
> submitted on the issue tracker were automatically submitted to this
> list, but alas they are not. There should be really annoying blinking
> text on the issue tracker saying that patches will not be looked at
> unless they are sent to this list for review.
> 
> Would you be willing to submit the patch to the list so it can be
> reviewed?
OK, here is the patch from bug #61620 as supplied by
https://savannah.gnu.org/users/rogier777

---------------------------------------------------
Index: grub2-2.02+dfsg1/grub-core/disk/lvm.c
===================================================================
--- grub2-2.02+dfsg1.orig/grub-core/disk/lvm.c
+++ grub2-2.02+dfsg1/grub-core/disk/lvm.c
@@ -253,7 +253,7 @@ error_parsing_metadata:

   p = q = (char *)ptr;

-  if (grub_add ((grub_size_t)metadatabuf, (grub_size_t)mda_size, &ptr))
+  if (grub_add (ptr, (grub_size_t)grub_le_to_cpu64 (rlocn->size), &ptr))
     goto error_parsing_metadata;

   mda_end = (char *)ptr;
----------------------------------------------------

> Glenn
Horst