Why is this patch needed? Should not we disable SSE using compiler flags?
We do but the code in question uses SSE on every x64 platform. So we need to disable this acceleration. At least for now. If we want to enable SSE (maybe we should) we can revisit this but this is a separate discussion and separate patchset
Daniel
On Thu, May 16, 2024 at 09:27:43PM +0300, Vladimir Serbinenko wrote:
> ---
> grub-core/lib/libgcrypt/cipher/keccak.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/grub-core/lib/libgcrypt/cipher/keccak.c b/grub-core/lib/libgcrypt/cipher/keccak.c
> index 11e64b3e7..8b570263b 100644
> --- a/grub-core/lib/libgcrypt/cipher/keccak.c
> +++ b/grub-core/lib/libgcrypt/cipher/keccak.c
> @@ -251,7 +251,7 @@ keccak_absorb_lane32bi(u32 *lane, u32 x0, u32 x1)
> /* Construct generic 64-bit implementation. */
> #ifdef USE_64BIT
>
> -#if __GNUC__ >= 4 && defined(__x86_64__)
> +#if __GNUC__ >= 4 && defined(__x86_64__) && 0
>
> static inline void absorb_lanes64_8(u64 *dst, const byte *in)
> {