Re: [PATCH 01/15] modules: make .module_license read-only

[Vladimir 'phcoder' Serbinenko]

Reviewed-By: Vladimir Serbinenko

On Fri, May 24, 2024 at 2:05 PM Mate Kukri <mate.kukri@canonical.com> wrote:
>
> From: Peter Jones <pjones@redhat.com>
>
> Currently .module_license is set writable (that is, the section has the
> SHF_WRITE flag set) in the module's ELF headers.  This probably never
> actually matters, but it can't possibly be correct.
>
> This patch sets that data as "const", which causes that flag not to be
> set.
>
> Signed-off-by: Peter Jones <pjones@redhat.com>
> (cherry picked from commit f6563e15bb490bb76a1a95cd3648fe03d1134d14)
> Signed-off-by: Jan Setje-Eilers <jan.setjeeilers@oracle.com>
> Signed-off-by: Mate Kukri <mate.kukri@canonical.com>
> ---
>  include/grub/dl.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/grub/dl.h b/include/grub/dl.h
> index cd1f46c8b..750fc8d3d 100644
> --- a/include/grub/dl.h
> +++ b/include/grub/dl.h
> @@ -119,7 +119,7 @@ grub_mod_fini (void)
>  #define ATTRIBUTE_USED __unused__
>  #endif
>  #define GRUB_MOD_LICENSE(license)      \
> -  static char grub_module_license[] __attribute__ ((section 
> (GRUB_MOD_SECTION (module_license)), ATTRIBUTE_USED)) = "LICENSE=" license;
> +  static const char grub_module_license[] __attribute__ ((section 
> (GRUB_MOD_SECTION (module_license)), ATTRIBUTE_USED)) = "LICENSE=" license;
>  #define GRUB_MOD_DEP(name)     \
>  static const char grub_module_depend_##name[] \
>   __attribute__((section(GRUB_MOD_SECTION(moddeps)), ATTRIBUTE_USED)) = #name
> --
> 2.39.2
>
>
> _______________________________________________
> Grub-devel mailing list
> Grub-devel@gnu.org
> https://lists.gnu.org/mailman/listinfo/grub-devel



-- 
Regards
Vladimir 'phcoder' Serbinenko