[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v16 03/20] libtasn1: disable code not needed in grub
From: |
Daniel Kiper |
Subject: |
Re: [PATCH v16 03/20] libtasn1: disable code not needed in grub |
Date: |
Wed, 5 Jun 2024 17:18:32 +0200 |
On Wed, May 15, 2024 at 01:06:55PM +0800, Gary Lin wrote:
> From: Daniel Axtens <dja@axtens.net>
>
> We don't expect to be able to write ASN.1, only read it,
> so we can disable some code.
>
> Do that with #if 0/#endif, rather than deletion. This means
> that the difference between upstream and grub is smaller,
> which should make updating libtasn1 easier in the future.
>
> With these exclusions we also avoid the need for minmax.h,
> which is convenient because it means we don't have to
> import it from gnulib.
This and two following patches should be put in separate files in the
grub-core/lib/libtasn1-patches directory. The gnulib is good example
how it should be done.
Daniel
- Re: [PATCH v16 03/20] libtasn1: disable code not needed in grub,
Daniel Kiper <=