Re: [PATCH v16 01/20] posix_wrap: tweaks in preparation for libtasn1

[Gary Lin]

On Wed, Jun 05, 2024 at 04:45:07PM +0200, Daniel Kiper wrote:
> On Wed, May 15, 2024 at 01:06:53PM +0800, Gary Lin wrote:
> > From: Daniel Axtens <dja@axtens.net>
> >
> >  - Define SIZEOF_UNSIGNED_LONG_INT, it's the same as
> >    SIZEOF_UNSIGNED_LONG.
> >
> >  - Define WORD_BIT, the size in bits of an int. This is a defined
> >    in the Single Unix Specification and in gnulib's limits.h. gnulib
> >    assumes it's 32 bits on all our platforms, including 64 bit
> >    platforms, so we also use that value.
> >
> >  - Provide strto[u]l[l] preprocessor macros that resolve to
> >    grub_strto[u]l[l]. To avoid gcrypt redefining strtoul, we
> >    also define HAVE_STRTOUL here.
> >
> >  - Implement c-ctype.h and the functions defined in the header.
> >
> >  - Implement strncat in string.h.
> >
> > Cc: Vladimir Serbinenko <phcoder@gmail.com>
> > Signed-off-by: Daniel Axtens <dja@axtens.net>
> > Signed-off-by: Gary Lin <glin@suse.com>
> 
> Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> 
> A nit below...
> 
> > diff --git a/grub-core/lib/posix_wrap/string.h 
> > b/grub-core/lib/posix_wrap/string.h
> > index 1adb450b5..b0c5928d2 100644
> > --- a/grub-core/lib/posix_wrap/string.h
> > +++ b/grub-core/lib/posix_wrap/string.h
> > @@ -84,6 +84,27 @@ memchr (const void *s, int c, grub_size_t n)
> >    return grub_memchr (s, c, n);
> >  }
> >
> > +static inline char *
> > +strncat(char *dest, const char *src, grub_size_t n)
> 
> Missing space before "(".
> 
Will fix in v17.

Thanks,

Gary Lin