Re: [PATCH v15 3/3] fs/erofs: Add tests for EROFS in grub-fs-tester

[Glenn Washburn]

On Mon, 10 Jun 2024 10:33:16 +0800
Yifan Zhao <zhaoyifan@sjtu.edu.cn> wrote:

> Hi Glenn,
> 
> 
> erofs-utils supports this -L flag since version 1.6.
> 
> Do you think removing the label-related tests to maintain compatibility 
> with the older versions of erofs-utils is a good idea?

I thought also about just disabling the label tests, but I would rather
not. I think the version of mkfs.erofs should be checked and only run
the label tests if the version is >= 1.6.

Glenn

> 
> 
> Thanks,
> 
> Yifan Zhao
> 
> 
> On 2024/6/10 3:33, Glenn Washburn wrote:
> > I am not running this test and it is failing because mkfs.erofs has no
> > "-L" option. I'm on Debian's erofs-utils version 1.5. According to that
> > versions help, I don't see a way to set the label, only the uuid. Are
> > you using a different version of erofs-utils to run these tests?