[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/3] kern/efi/mm: Change grub_efi_mm_add_regions() to keep tr
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH 1/3] kern/efi/mm: Change grub_efi_mm_add_regions() to keep track of map allocation size |
|
Date: |
Wed, 12 Jun 2024 18:02:24 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Jun 12, 2024 at 04:10:49PM +0100, Mate Kukri wrote:
> If the map was too big for the initial allocation, it was freed and replaced
> with a bigger one, but the free call still used the hard-coded size.
>
> Seems like this wasn't hit for a long time, because most firmware maps
> fit into 12K.
>
> This bug was trigerred on Project Mu firmware with a big memory map, and
> results in the heap getting trashed and the firmware ASSERTING on
> corrupted heap guard values when GRUB exits.
>
> Signed-off-by: Mate Kukri <mate.kukri@canonical.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel