[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 3/3] kern/efi/mm: Detect calls to grub_efi_drop_alloc() with
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH 3/3] kern/efi/mm: Detect calls to grub_efi_drop_alloc() with wrong page counts |
|
Date: |
Wed, 12 Jun 2024 18:03:42 +0200 |
|
User-agent: |
NeoMutt/20170113 (1.7.2) |
On Wed, Jun 12, 2024 at 04:14:21PM +0100, Mate Kukri wrote:
> Silently keeping entries in the list if the address matches, but the
> page count doesn't is a bad idea, and can lead to double frees.
>
> grub_efi_free_pages() have already freed parts of this block by this
> point, and thus keeping the whole block in the list and freeing it again
> at exit can lead to double frees.
>
> Signed-off-by: Mate Kukri <mate.kukri@canonical.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel