[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v17 03/20] libtasn1: disable code not needed in grub
|
From: |
Daniel Kiper |
|
Subject: |
Re: [PATCH v17 03/20] libtasn1: disable code not needed in grub |
|
Date: |
Mon, 17 Jun 2024 17:06:35 +0200 |
On Fri, Jun 14, 2024 at 02:45:36PM +0800, Gary Lin wrote:
> Based on the patch from "Daniel Axtens <dja@axtens.net>"
>
> We don't expect to be able to write ASN.1, only read it,
> so we can disable some code.
>
> Do that with #if 0/#endif, rather than deletion. This means
> that the difference between upstream and grub is smaller,
> which should make updating libtasn1 easier in the future.
>
> With these exclusions we also avoid the need for minmax.h,
> which is convenient because it means we don't have to
> import it from gnulib.
>
> Signed-off-by: Gary Lin <glin@suse.com>
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
Daniel
- [PATCH v17 00/20] Automatic Disk Unlock with TPM2, Gary Lin, 2024/06/14
- [PATCH v17 01/20] posix_wrap: tweaks in preparation for libtasn1, Gary Lin, 2024/06/14
- [PATCH v17 03/20] libtasn1: disable code not needed in grub, Gary Lin, 2024/06/14
- Re: [PATCH v17 03/20] libtasn1: disable code not needed in grub,
Daniel Kiper <=
- [PATCH v17 02/20] libtasn1: import libtasn1-4.19.0, Gary Lin, 2024/06/14
- [PATCH v17 05/20] libtasn1: fix the potential buffer overrun, Gary Lin, 2024/06/14
- [PATCH v17 06/20] libtasn1: compile into asn1 module, Gary Lin, 2024/06/14
- [PATCH v17 04/20] libtasn1: changes for grub compatibility, Gary Lin, 2024/06/14