Re: [PATCH v4 07/10] nx: set the nx compatible flag in EFI grub images

[Daniel Kiper]

On Wed, Jun 12, 2024 at 04:57:10PM +0100, Mate Kukri wrote:
> For NX, we need the grub binary to announce that it is compatible with

s/grub/GRUB/

> the NX feature.  This implies that when loading the executable grub

Ditto. May I ask you to use correct project name?

> image, several attributes are true:
>
> - the binary doesn't need an executable stack
> - the binary doesn't need sections to be both executable and writable
> - the binary knows how to use the EFI Memory Attributes protocol on code
>   it is loading.
>
> This patch
> - adds a definition for the PE DLL Characteristics flag GRUB_PE32_NX_COMPAT
> - changes grub-mkimage to set that flag.
>
> Original-Author: Peter Jones <pjones@redhat.com>
> Signed-off-by: Mate Kukri <mate.kukri@canonical.com>

If you fix nits mentioned above then you can add
Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>...

Daniel