Re: [PATCH v18 12/25] key_protector: Add key protectors framework

[Vladimir 'phcoder' Serbinenko]

> +  if (protector == NULL || protector->name == NULL || grub_strlen 
> (protector->name) == 0)
> +    return GRUB_ERR_BAD_ARGUMENT;
> +
Here and in the other places you miss grub_error. Note that the
message in such technical cases should be left untranslated (no N_
mark).

> +  if (protector == NULL || grub_strlen (protector) == 0)

Rather than checking strlen just do protector[0] == '\0'