Re: [PATCH v3 24/29] btrfs: export btrfs_subvol and btrfs_subvolid

[Neal Gompa]

On Mon, Oct 14, 2024 at 1:10 PM Leo Sandoval <lsandova@redhat.com> wrote:
>
> From: Michael Chang <mchang@suse.com>
>
> We should export btrfs_subvol and btrfs_subvolid to have both visible
> to subsidiary configuration files loaded using configfile.
>
> Signed-off-by: Michael Chang <mchang@suse.com>
> ---
>  grub-core/fs/btrfs.c | 2 ++
>  1 file changed, 2 insertions(+)
>
> diff --git a/grub-core/fs/btrfs.c b/grub-core/fs/btrfs.c
> index 8e2b1e9f7..14e38a4df 100644
> --- a/grub-core/fs/btrfs.c
> +++ b/grub-core/fs/btrfs.c
> @@ -2920,6 +2920,8 @@ GRUB_MOD_INIT (btrfs)
>                                 subvol_set_env);
>    grub_register_variable_hook ("btrfs_subvolid", subvolid_get_env,
>                                 subvolid_set_env);
> +  grub_env_export ("btrfs_subvol");
> +  grub_env_export ("btrfs_subvolid");
>  }
>
>  GRUB_MOD_FINI (btrfs)
> --
> 2.46.2
>

LGTM. :)

Reviewed-by: Neal Gompa <ngompa13@gmail.com>



-- 
真実はいつも一つ！/ Always, there's only one truth!