grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1 0/5] Fedora Rawhide BTRFS patches


From: Vladimir 'phcoder' Serbinenko
Subject: Re: [PATCH v1 0/5] Fedora Rawhide BTRFS patches
Date: Mon, 4 Nov 2024 19:42:30 +0300

I think the entire series is bad if I understand it correctly. I ask the same question again: are some files inaccessible with current code but become accessible with these patches? Aka can I create a file that I can't read with grub-fstest in the current code?
 GRUB2 follows strict design that same full file name refers to the same file and doesn't have some hidden state. It's possible to add some state outside of disk drivers like having an analog of relative paths or handling it on script level but the fs drivers are definitely not the right place to patch up the difference between mount-based unix model and full path model used in GRUB.

Le jeu. 31 oct. 2024, 22:43, Leo Sandoval <lsandova@redhat.com> a écrit :
This series contains BTRFS patches taken from Fedora Rawhide [1]. Some of
these patches have already being sent [2][3] however, as suggested
by Daniel Kiper, to make the review easier, I took only BTRFS related patches
from [1][2][3] and create the series.

[1] https://src.fedoraproject.org/rpms/grub2
[2] https://lists.gnu.org/archive/html/grub-devel/2024-10/msg00145.html
[3] https://lists.gnu.org/archive/html/grub-devel/2024-10/msg00192.html

Jeff Mahoney (1):
  btrfs: Add ability to boot from subvolumes

Michael Chang (2):
  btrfs: export btrfs_subvol and btrfs_subvolid
  btrfs: Allow specifying btrfs_relative_path to follow the default
    subvolume

Peter Jones (2):
  btrfs: fix a bad null check
  btrfs: Fixup for newer compiler

 grub-core/fs/btrfs.c | 629 ++++++++++++++++++++++++++++++++++++++++---
 include/grub/btrfs.h |   1 +
 2 files changed, 595 insertions(+), 35 deletions(-)

--
2.46.2


_______________________________________________
Grub-devel mailing list
Grub-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/grub-devel

reply via email to

[Prev in Thread] Current Thread [Next in Thread]