Re: [PATCH v21 21/33] tss2: Add TPM2 types and Marshal/Unmarshal functions

[Gary Lin]

On Mon, Nov 04, 2024 at 01:20:45PM -0500, Stefan Berger wrote:
> 
> 
> On 11/4/24 2:31 AM, Gary Lin via Grub-devel wrote:
> > This commit adds the necessary TPM2 types and structs as the preparation
> > for the TPM2 Software Stack (TSS2) support. The Marshal/Unmarshal
> > functions are also added to handle the data structure to be submitted to
> > TPM2 commands and to be received from the response.
> > 
> > Cc: Stefan Berger <stefanb@linux.ibm.com>
> > Signed-off-by: Hernan Gatta <hegatta@linux.microsoft.com>
> > Signed-off-by: Gary Lin <glin@suse.com>
> > Reviewed-by: Daniel Kiper <daniel.kiper@oracle.com>
> > ---
> >   grub-core/lib/tss2/tss2_mu.c      | 1174 +++++++++++++++++++++++++++++
> >   grub-core/lib/tss2/tss2_mu.h      |  397 ++++++++++
> >   grub-core/lib/tss2/tss2_structs.h |  796 +++++++++++++++++++
> >   grub-core/lib/tss2/tss2_types.h   |  404 ++++++++++
> >   4 files changed, 2771 insertions(+)
> >   create mode 100644 grub-core/lib/tss2/tss2_mu.c
> >   create mode 100644 grub-core/lib/tss2/tss2_mu.h
> >   create mode 100644 grub-core/lib/tss2/tss2_structs.h
> >   create mode 100644 grub-core/lib/tss2/tss2_types.h
> > 
> 
> > +
> > +/* Buffer Size Constants */
> > +#define TPM_MAX_PCRS                      32
> 
> This should be 24 and it seems that it can be changed easily.
> 
It is from tpm2-tss:
https://github.com/tpm2-software/tpm2-tss/blob/master/include/tss2/tss2_tpm2_types.h#L25

I'm still trying to find out where the number is from.

Gary Lin

> Reviewed-by: Stefan Berger <stefanb@linux.ibm.com>
>