grub-devel
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2 1/3] commands/ls: Allow printing mtime for file arguments


From: Daniel Kiper
Subject: Re: [PATCH v2 1/3] commands/ls: Allow printing mtime for file arguments
Date: Wed, 27 Nov 2024 17:23:49 +0100
User-agent: NeoMutt/20170113 (1.7.2)

On Sat, Jun 08, 2024 at 04:58:31PM -0500, Glenn Washburn wrote:
> File arguments were processed differently than files listed from directory
> arguments. A side effect of this was that mtime was not shown for file
> arguments when long listing was enabled. Refactor to have the same code
> path for printing files that are arguments and ones that are contained in
> directories. This also has the added benefit of simplifying the code path.

I think you are doing at least three different things in this patch. First
you change how print_files_long() works. Than you replace print_files()
and print_files_long() with print_files(). And finally you change how the
ls works in general. So, I can see three patches here...

Daniel



reply via email to

[Prev in Thread] Current Thread [Next in Thread]