[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 0/6 v13] LVM Cachevol and Integrity volumes break entire LVM
From: |
Glenn Washburn |
Subject: |
Re: [PATCH 0/6 v13] LVM Cachevol and Integrity volumes break entire LVM VG |
Date: |
Sat, 4 Jan 2025 19:31:53 -0600 |
Hi Patrick,
It looks like you're not using the --thread option for git
format-patch. Would you please use that for the next version? That
option will keep the patch set together for those with email clients
with threaded view. Thanks.
Glenn
On Sat, 4 Jan 2025 15:16:59 -0500
Patrick Plenefisch <simonpatp@gmail.com> wrote:
> In an effort to solve
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=1061168 for myself,
> I implemented basic support for cachevol and integrity volumes in LVM.
>
> This is just an extension of the cachepool support that already
> existed, and just like that support, I ignore all of the metadata and
> just go for the data. This obviously means that writing to "writeback"
> cachepools, and any raidintegrity volumes will cause corruption as
> before, but as grub only reads files, I think that should be fine.
>
> Without these patches, a system with /boot on a LV in a VG that also
> has cachevol or integrity volumes will fail to boot.
>
> These patches are also available attached and at
> https://github.com/byteit101/grub2/commits/grub-lvmintegrity/
>
> This is identical to the previous versions, except for changed commit
> messages on patch 5.
>
> Patrick Plenefisch (6):
> disk/lvm: Make cache_lv more generic as ignored_feature_lv
> disk/lvm: Remove unused cache_pool
> lvm: Match all lvm segments before validation
> lvm: Add support for integrity lv
> lvm: add informational messages in error cases of ignored features
> lvm: Add support for cachevol lv
>
> grub-core/disk/diskfilter.c | 6 +-
> grub-core/disk/lvm.c | 267 ++++++++++++++++++------------------
> 2 files changed, 136 insertions(+), 137 deletions(-)
>