[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[Guile-commits] 11/13: Do not depend on tmpnam in posix.test.
From: |
Ludovic Courtès |
Subject: |
[Guile-commits] 11/13: Do not depend on tmpnam in posix.test. |
Date: |
Sun, 20 Oct 2024 15:23:23 -0400 (EDT) |
civodul pushed a commit to branch main
in repository guile.
commit ff256c356be9327c24a2d7fc0f007722422e6604
Author: Tomas Volf <~@wolfsden.cz>
AuthorDate: Sat Aug 10 00:54:34 2024 +0200
Do not depend on tmpnam in posix.test.
`tmpnam' is a deprecated procedure that can be excluded during a
configure (`--disable-tmpnam'). There currently was a single test
relying on it, and therefore failing is such configuration. This commit
switches to mkstemp instead.
* test-suite/tests/posix.test ("system*"): Use mkstemp instead of
tmpnam.
Signed-off-by: Ludovic Courtès <ludo@gnu.org>
---
test-suite/tests/posix.test | 6 ++++--
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/test-suite/tests/posix.test b/test-suite/tests/posix.test
index 310f3ac7c..7b7590b9b 100644
--- a/test-suite/tests/posix.test
+++ b/test-suite/tests/posix.test
@@ -365,7 +365,8 @@
(pass-if-equal "https://bugs.gnu.org/52835"
"bong\n"
- (let ((file (tmpnam)))
+ (let* ((port (mkstemp "T-XXXXXX"))
+ (file (port-filename port)))
;; Redirect stdout and stderr to FILE.
(define status
(call-with-output-file file
@@ -376,8 +377,9 @@
(lambda ()
(system* "sh" "-c" "echo bong >&2"))))))))
+ (delete-file file)
(and (zero? (status:exit-val status))
- (call-with-input-file file get-string-all))))
+ (get-string-all port))))
(pass-if-equal "https://bugs.gnu.org/63024"
0
- [Guile-commits] branch main updated (08e26836f -> faa8ab8a8), Ludovic Courtès, 2024/10/20
- [Guile-commits] 01/13: Replace SRFI-64 with a new implementation., Ludovic Courtès, 2024/10/20
- [Guile-commits] 07/13: filesys.c: Fix readlink for ports on Darwin., Ludovic Courtès, 2024/10/20
- [Guile-commits] 05/13: tests: Skip tests of abstract Unix sockets on Darwin., Ludovic Courtès, 2024/10/20
- [Guile-commits] 03/13: Fix typo in dynamic wind documentation., Ludovic Courtès, 2024/10/20
- [Guile-commits] 02/13: Fix gbt command in gdbinit, Ludovic Courtès, 2024/10/20
- [Guile-commits] 04/13: tests: Check TCP_NODELAY for non-zero instead of 1., Ludovic Courtès, 2024/10/20
- [Guile-commits] 10/13: tests: Fix spawn if file not found with Gnulib., Ludovic Courtès, 2024/10/20
- [Guile-commits] 08/13: tests: Skip mkdtemp test for invalid template on Darwin., Ludovic Courtès, 2024/10/20
- [Guile-commits] 06/13: tests: Skip hole-related port tests on Darwin., Ludovic Courtès, 2024/10/20
- [Guile-commits] 11/13: Do not depend on tmpnam in posix.test.,
Ludovic Courtès <=
- [Guile-commits] 09/13: tests: Fix spawn with #:environment on MacOS., Ludovic Courtès, 2024/10/20
- [Guile-commits] 12/13: posix.c: Set errno when pipe2 is not available and flags provided., Ludovic Courtès, 2024/10/20
- [Guile-commits] 13/13: Update NEWS., Ludovic Courtès, 2024/10/20