[Top][All Lists]
[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH 10/12] Guile-DBD-postgres: Fix off-by-one when fetching rows
From: |
Linas Vepstas |
Subject: |
[PATCH 10/12] Guile-DBD-postgres: Fix off-by-one when fetching rows |
Date: |
Fri, 19 Sep 2008 09:20:41 -0500 |
User-agent: |
Mutt/1.5.15+20070412 (2007-04-11) |
It appears that the current postgres dbd code will return one less
row than the database actually contains, which is a disaster if
the database holds only one row! Fix this.
Signed-off-by: Linas Vepstas <address@hidden>
---
src/guile-dbd-postgresql.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Index: guile-dbd-postgresql-2.0.0/src/guile-dbd-postgresql.c
===================================================================
--- guile-dbd-postgresql-2.0.0.orig/src/guile-dbd-postgresql.c 2008-09-15
14:10:33.000000000 -0500
+++ guile-dbd-postgresql-2.0.0/src/guile-dbd-postgresql.c 2008-09-15
14:11:02.000000000 -0500
@@ -299,7 +299,7 @@ __postgresql_getrow_g_db_handle(gdbi_db_
pgsqlP->lget = 0;
return (SCM_BOOL_F);
}
- else if (pgsqlP->lget == (PQntuples(pgsqlP->res) - 1))
+ else if (pgsqlP->lget == PQntuples(pgsqlP->res))
{
pgsqlP->res = PQgetResult(pgsqlP->pgsql);
}
signature.asc
Description: Digital signature
- PATCH [0/12]: Guile-DBI and Guile-DBD-Postgres, Linas Vepstas, 2008/09/19
- [PATCH 1/12] Guile-DBI: Avoid multiple init, Linas Vepstas, 2008/09/19
- [PATCH 2/12] Guile-DBI: minor cleanup, Linas Vepstas, 2008/09/19
- [PATCH 3/12] Guile-DBI: Fix memory leak, Linas Vepstas, 2008/09/19
- [PATCH 4/12] Guile-DBII: replace deprecated gh_ functions, Linas Vepstas, 2008/09/19
- [PATCH 6/12] Guile-DBI: Fix crash, avoid recursive free, Linas Vepstas, 2008/09/19
- [PATCH 5/12] Guile-DBI: Use remember_upto_here, Linas Vepstas, 2008/09/19
- [PATCH 7/12] Guile-DBI: Don't cast away const, Linas Vepstas, 2008/09/19
- [PATCH 8/12] Guile-DBD-postgres: Fix handling of float point columns, Linas Vepstas, 2008/09/19
- [PATCH 9/12] Guile-DBD-postgres: Avoid discouraged functions, Linas Vepstas, 2008/09/19
- [PATCH 10/12] Guile-DBD-postgres: Fix off-by-one when fetching rows,
Linas Vepstas <=
- [PATCH 11/12] Guile-DBD-postgres: Avoid deprecated functions, Linas Vepstas, 2008/09/19
- [PATCH 12/12] Guile-DBD-postgres: Crash in GC, Linas Vepstas, 2008/09/19
- Re: PATCH [0/12]: Guile-DBI and Guile-DBD-Postgres, Neil Jerram, 2008/09/19