[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
05/07: gexp: Native inputs of nested gexps are properly accounted for.
From: |
Ludovic Courtès |
Subject: |
05/07: gexp: Native inputs of nested gexps are properly accounted for. |
Date: |
Mon, 19 Dec 2016 16:53:08 +0000 (UTC) |
civodul pushed a commit to branch master
in repository guix.
commit 5b14a7902c58d9fb7923f9e16871f549fbe59b6e
Author: Ludovic Courtès <address@hidden>
Date: Mon Dec 19 17:06:12 2016 +0100
gexp: Native inputs of nested gexps are properly accounted for.
Previously, 'gexp-native-inputs' would not return the native inputs of
nested gexps. For example, this:
(gexp-native-inputs #~(foo #$#~(bar #+coreutils)))
would return '().
* guix/gexp.scm (gexp-inputs)[add-reference-inputs]: In the
non-recursive cases, check whether N? and NATIVE? are the same, and act
accordingly.
[native-input?]: Remove.
Fold over all of (gexp-references exp).
* tests/gexp.scm ("ungexp + ungexp-native, nested, special mixture"):
New test.
* tests/gexp.scm ("input list splicing + ungexp-native-splicing"): Pass
#:native? #t to 'gexp-input'.
---
guix/gexp.scm | 28 ++++++++++++----------------
tests/gexp.scm | 11 ++++++++++-
2 files changed, 22 insertions(+), 17 deletions(-)
diff --git a/guix/gexp.scm b/guix/gexp.scm
index fd5dc49..5021688 100644
--- a/guix/gexp.scm
+++ b/guix/gexp.scm
@@ -678,32 +678,28 @@ references; otherwise, return only non-native references."
(if (direct-store-path? str)
(cons `(,str) result)
result))
- (($ <gexp-input> (? struct? thing) output)
- (if (lookup-compiler thing)
+ (($ <gexp-input> (? struct? thing) output n?)
+ (if (and (eqv? n? native?) (lookup-compiler thing))
;; THING is a derivation, or a package, or an origin, etc.
(cons `(,thing ,output) result)
result))
(($ <gexp-input> (lst ...) output n?)
- (fold-right add-reference-inputs result
- ;; XXX: For now, automatically convert LST to a list of
- ;; gexp-inputs.
- (map (match-lambda
- ((? gexp-input? x) x)
- (x (%gexp-input x "out" (or n? native?))))
- lst)))
+ (if (eqv? native? n?)
+ (fold-right add-reference-inputs result
+ ;; XXX: For now, automatically convert LST to a list of
+ ;; gexp-inputs.
+ (map (match-lambda
+ ((? gexp-input? x) x)
+ (x (%gexp-input x "out" (or n? native?))))
+ lst))
+ result))
(_
;; Ignore references to other kinds of objects.
result)))
- (define (native-input? x)
- (and (gexp-input? x)
- (gexp-input-native? x)))
-
(fold-right add-reference-inputs
'()
- (if native?
- (filter native-input? (gexp-references exp))
- (remove native-input? (gexp-references exp)))))
+ (gexp-references exp)))
(define gexp-native-inputs
(cut gexp-inputs <> #:native? #t))
diff --git a/tests/gexp.scm b/tests/gexp.scm
index 354d28f..797d5fa 100644
--- a/tests/gexp.scm
+++ b/tests/gexp.scm
@@ -277,6 +277,14 @@
(ungexp %bootstrap-guile)))))
(list (gexp-inputs exp) '<> (gexp-native-inputs exp))))
+(test-equal "ungexp + ungexp-native, nested, special mixture"
+ `(() <> ((,coreutils "out")))
+
+ ;; (gexp-native-inputs exp) used to return '(), wrongfully.
+ (let* ((foo (gexp (foo (ungexp-native coreutils))))
+ (exp (gexp (bar (ungexp foo)))))
+ (list (gexp-inputs exp) '<> (gexp-native-inputs exp))))
+
(test-assert "input list"
(let ((exp (gexp (display
'(ungexp (list %bootstrap-guile coreutils)))))
@@ -327,7 +335,8 @@
`(list ,@(cons 5 outputs))))))
(test-assert "input list splicing + ungexp-native-splicing"
- (let* ((inputs (list (gexp-input glibc "debug") %bootstrap-guile))
+ (let* ((inputs (list (gexp-input glibc "debug" #:native? #t)
+ %bootstrap-guile))
(exp (gexp (list (ungexp-native-splicing (cons (+ 2 3) inputs))))))
(and (lset= equal?
`((,glibc "debug") (,%bootstrap-guile "out"))
- branch master updated (43686dc -> 834d122), Ludovic Courtès, 2016/12/19
- 01/07: doc: Mention 'swapon'., Ludovic Courtès, 2016/12/19
- 05/07: gexp: Native inputs of nested gexps are properly accounted for.,
Ludovic Courtès <=
- 04/07: services: Use 'file-append' in more places., Ludovic Courtès, 2016/12/19
- 03/07: doc: Mention 'grub' field of 'grub-configuration'., Ludovic Courtès, 2016/12/19
- 02/07: doc: Make 'guix pull' more visible., Ludovic Courtès, 2016/12/19
- 06/07: gexp: Slightly simplify 'gexp-inputs'., Ludovic Courtès, 2016/12/19
- 07/07: gnu: kdbusaddons: Embed kinit store dir, avoid dependency cycles., Ludovic Courtès, 2016/12/19