guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

03/03: gnu: tar: Skip racy tests.


From: Marius Bakke
Subject: 03/03: gnu: tar: Skip racy tests.
Date: Fri, 6 Apr 2018 14:34:39 -0400 (EDT)

mbakke pushed a commit to branch core-updates
in repository guix.

commit 169c658f7f286efae397fa3eda55b1c56fa92a01
Author: Marius Bakke <address@hidden>
Date:   Fri Apr 6 15:22:24 2018 +0200

    gnu: tar: Skip racy tests.
    
    * gnu/packages/base.scm (tar)[arguments]: Skip two more tests in 
#:make-flags.
---
 gnu/packages/base.scm | 10 +++++++++-
 1 file changed, 9 insertions(+), 1 deletion(-)

diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index 88eaee7..1be63c3 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -191,7 +191,15 @@ implementation offers several extensions over the standard 
utility.")
       ;; "a/y: Not linked to a/z" and fails, presumably due to differences in
       ;; the order in which 'diff' traverses directories.  That leads to a
       ;; test failure even though conceptually the test passes.  Skip it.
-      #:make-flags '("TESTSUITEFLAGS=-k '!link mismatch'")))
+      ;; Test 117 and 118 are prone to race conditions too, particularly
+      ;; when cross-compiling, so we skip those as well.  All issues have
+      ;; been fixed upstream in these commits:
+      ;; <https://git.savannah.gnu.org/cgit/tar.git/commit/?id=847a36f>
+      ;; <https://git.savannah.gnu.org/cgit/tar.git/commit/?id=64b43fd>
+      #:make-flags (list (string-append
+                          "TESTSUITEFLAGS= -k '!link mismatch,"
+                          "!directory removed before reading,"
+                          "!explicitly named directory removed before 
reading'"))))
 
    ;; When cross-compiling, the 'set-shell-file-name' phase needs to be able
    ;; to refer to the target Bash.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]