04/04: gnu: samba: Prepare for tests.

[guix-commits]

apteryx pushed a commit to branch master
in repository guix.

commit 25e811583fc1e718668147e50a0bf297b30e8017
Author: Maxim Cournoyer <maxim.cournoyer@gmail.com>
AuthorDate: Mon Nov 2 22:03:18 2020 -0500

    gnu: samba: Prepare for tests.
    
    * gnu/packages/samba.scm (samba)[arguments]: Update comment regarding the 
test
    suite failure.
    [make-flags]: Run the test suite with the '--quick' option, as it is very 
slow otherwise.
    [phases]{configure}: Add the '--enable-selftest' argument.
    [inputs]: Add libtirpc.
---
 gnu/packages/samba.scm | 10 ++++++----
 1 file changed, 6 insertions(+), 4 deletions(-)

diff --git a/gnu/packages/samba.scm b/gnu/packages/samba.scm
index 8f723d5..a6610bb 100644
--- a/gnu/packages/samba.scm
+++ b/gnu/packages/samba.scm
@@ -197,7 +197,8 @@ external dependencies.")
            #t))))
     (build-system gnu-build-system)
     (arguments
-     `(#:phases
+     `(#:make-flags '("TEST_OPTIONS=--quick") ;some tests are very long
+       #:phases
        (modify-phases %standard-phases
          (add-before 'configure 'setup-docbook-stylesheets
            (lambda* (#:key inputs #:allow-other-keys)
@@ -219,6 +220,7 @@ external dependencies.")
              (let* ((out    (assoc-ref outputs "out"))
                     (libdir (string-append out "/lib")))
                (invoke "./configure"
+                       "--enable-selftest"
                        "--enable-fhs"
                        (string-append "--prefix=" out)
                        "--sysconfdir=/etc"
@@ -232,9 +234,8 @@ external dependencies.")
              (substitute* "dynconfig/wscript"
                (("bld\\.INSTALL_DIR.*") ""))
              #t)))
-       ;; XXX: The test infrastructure attempts to set password with
-       ;; smbpasswd, which fails with "smbpasswd -L can only be used by root."
-       ;; So disable tests until there's a workaround.
+       ;; FIXME: The test suite seemingly hangs after failing to provision the
+       ;; test environment.
        #:tests? #f))
     (inputs
      `(("acl" ,acl)
@@ -247,6 +248,7 @@ external dependencies.")
        ("heimdal" ,heimdal)
        ("jansson" ,jansson)
        ("libarchive" ,libarchive)
+       ("libtirpc" ,libtirpc)
        ("linux-pam" ,linux-pam)
        ("lmdb" ,lmdb)
        ("openldap" ,openldap)