guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[no subject]


From: Christopher Baines
Date: Mon, 7 Dec 2020 04:48:47 -0500 (EST)

branch: master
commit 068ad30a270dae422a65ddfa261aae9d458f4517
Author: Christopher Baines <mail@cbaines.net>
AuthorDate: Sun Dec 6 10:57:44 2020 +0000

    database: Don't finalise cached statements.
    
    All these statements are cached, but that's pointless if they're finalized
    after use, because they'll need recreating on next use.
    
    * src/cuirass/database.scm (%sqlite-exec, db-get-builds-query-min,
    db-get-builds-query-max): Replace sqlite-finalize with sqlite-reset.
---
 src/cuirass/database.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/src/cuirass/database.scm b/src/cuirass/database.scm
index 7bbf467..63c3525 100644
--- a/src/cuirass/database.scm
+++ b/src/cuirass/database.scm
@@ -117,7 +117,7 @@ rows."
                 (sqlite-bind stmt index (normalize arg)))
               args (iota (length args) 1))
     (let ((result (sqlite-fold-right cons '() stmt)))
-      (sqlite-finalize stmt)
+      (sqlite-reset stmt)
       result)))
 
 (define-syntax sqlite-exec/bind
@@ -1292,7 +1292,7 @@ AND (:system IS NULL
              (query->bind-arguments query))
       (sqlite-reset stmt)
       (let ((rows (sqlite-fold-right cons '() stmt)))
-        (sqlite-finalize stmt)
+        (sqlite-reset stmt)
         (and=> (expect-one-row rows) vector->list)))))
 
 (define (db-get-builds-query-max query)
@@ -1313,7 +1313,7 @@ AND (:system IS NULL
              (query->bind-arguments query))
       (sqlite-reset stmt)
       (let ((rows (sqlite-fold-right cons '() stmt)))
-        (sqlite-finalize stmt)
+        (sqlite-reset stmt)
         (and=> (expect-one-row rows) vector->list)))))
 
 (define (db-get-builds-min eval status)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]