[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
03/10: gexp: Micro-optimize sexp serialization.
From: |
guix-commits |
Subject: |
03/10: gexp: Micro-optimize sexp serialization. |
Date: |
Tue, 23 Feb 2021 09:27:23 -0500 (EST) |
civodul pushed a commit to branch master
in repository guix.
commit bde7929bd06196ed84f96d08676ee43da4685975
Author: Ludovic Courtès <ludo@gnu.org>
AuthorDate: Sat Mar 28 21:44:01 2015 +0100
gexp: Micro-optimize sexp serialization.
* guix/gexp.scm (sexp->string): New procedure.
(gexp->derivation): Use it instead of 'object->string'.
---
guix/gexp.scm | 13 +++++++++++--
1 file changed, 11 insertions(+), 2 deletions(-)
diff --git a/guix/gexp.scm b/guix/gexp.scm
index 764c89a..8dd824c 100644
--- a/guix/gexp.scm
+++ b/guix/gexp.scm
@@ -1,5 +1,5 @@
;;; GNU Guix --- Functional package management for GNU
-;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019, 2020 Ludovic Courtès
<ludo@gnu.org>
+;;; Copyright © 2014, 2015, 2016, 2017, 2018, 2019, 2020, 2021 Ludovic Courtès
<ludo@gnu.org>
;;; Copyright © 2018 Clément Lassieur <clement@lassieur.org>
;;; Copyright © 2018 Jan Nieuwenhuizen <janneke@gnu.org>
;;; Copyright © 2019, 2020 Mathieu Othacehe <m.othacehe@gmail.com>
@@ -941,6 +941,15 @@ second element is the derivation to compile them."
modules
system extensions guile deprecation-warnings module-path))
+(define (sexp->string sexp)
+ "Like 'object->string', but deterministic and slightly faster."
+ ;; Explicitly use UTF-8 for determinism, and also because UTF-8 output is
+ ;; faster.
+ (with-fluids ((%default-port-encoding "UTF-8"))
+ (call-with-output-string
+ (lambda (port)
+ (write sexp port)))))
+
(define* (lower-gexp exp
#:key
(module-path %load-path)
@@ -1159,7 +1168,7 @@ The other arguments are as for 'derivation'."
(return #f)))
(guile -> (lowered-gexp-guile lowered))
(builder (text-file script-name
- (object->string
+ (sexp->string
(lowered-gexp-sexp lowered)))))
(mbegin %store-monad
(set-grafting graft?) ;restore the initial setting
- branch master updated (3c548c3 -> 0a912b3), guix-commits, 2021/02/23
- 03/10: gexp: Micro-optimize sexp serialization.,
guix-commits <=
- 01/10: grafts: Inline 'grafting?' and 'set-grafting'., guix-commits, 2021/02/23
- 04/10: gexp: 'gexp-inputs' returns a list of <gexp-input> records., guix-commits, 2021/02/23
- 05/10: gexp: 'gexp-inputs' returns both native and non-native inputs., guix-commits, 2021/02/23
- 08/10: gexp: Reduce allocations while traversing lists., guix-commits, 2021/02/23
- 07/10: gexp: Micro-optimize 'gexp->sexp' and 'lower-inputs'., guix-commits, 2021/02/23
- 06/10: gexp: Keep 'lower-inputs' private., guix-commits, 2021/02/23
- 09/10: gexp: Reduce allocations in 'gexp-attribute'., guix-commits, 2021/02/23
- 10/10: store: Micro-optimize object cache lookup., guix-commits, 2021/02/23
- 02/10: store: Object cache profiling shows the number of entries., guix-commits, 2021/02/23