guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

01/02: gnu: python-pymediainfo: Simplify check phase.


From: guix-commits
Subject: 01/02: gnu: python-pymediainfo: Simplify check phase.
Date: Thu, 18 Nov 2021 10:31:29 -0500 (EST)

rekado pushed a commit to branch core-updates-frozen
in repository guix.

commit 0525a3de76206a1df57f448dde5f4f8addbdbcdf
Author: Ricardo Wurmus <rekado@elephly.net>
AuthorDate: Thu Nov 18 15:30:20 2021 +0000

    gnu: python-pymediainfo: Simplify check phase.
    
    * gnu/packages/python-xyz.scm (python-pymediainfo)[arguments]: Use
    ADD-INSTALLED-PYTHONPATH instead of manipulating PYTHONPATH directly.
---
 gnu/packages/python-xyz.scm | 10 ++++------
 1 file changed, 4 insertions(+), 6 deletions(-)

diff --git a/gnu/packages/python-xyz.scm b/gnu/packages/python-xyz.scm
index 5f99073..240955c 100644
--- a/gnu/packages/python-xyz.scm
+++ b/gnu/packages/python-xyz.scm
@@ -940,13 +940,11 @@ to CommonMark.")
                 (search-input-file %build-inputs
                                    "/lib/libmediainfo.so.0")))))
          (replace 'check
-           (lambda* (#:key tests? #:allow-other-keys)
+           (lambda* (#:key tests? inputs outputs #:allow-other-keys)
              (when tests?
-               ;; Extend PYTHONPATH so the built package will be found.
-               (setenv "PYTHONPATH"
-                       (string-append (getcwd) "/build/lib:"
-                                      (getenv "PYTHONPATH")))
-               ;; Skip the only failing test "test_parse_url"
+               (add-installed-pythonpath inputs outputs)
+               ;; Skip the only failing test "test_parse_url" because it tries
+               ;; to access the internet.
                (invoke "pytest" "-vv" "-k" "not test_parse_url")))))))
     (home-page
      "https://github.com/sbraz/pymediainfo";)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]