guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

02/02: gnu: %final-inputs-riscv64: Add comment.


From: guix-commits
Subject: 02/02: gnu: %final-inputs-riscv64: Add comment.
Date: Tue, 1 Feb 2022 05:34:57 -0500 (EST)

efraim pushed a commit to branch master
in repository guix.

commit c5000dcc375229ff42727f090d4243107d3a04a6
Author: Efraim Flashner <efraim@flashner.co.il>
AuthorDate: Tue Feb 1 12:33:28 2022 +0200

    gnu: %final-inputs-riscv64: Add comment.
    
    * gnu/packages/commencement.scm (%final-inputs-riscv64): Add comment
    explaining why this variable needs to exist.
---
 gnu/packages/commencement.scm | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/gnu/packages/commencement.scm b/gnu/packages/commencement.scm
index 96d914344d..3fb4b2054f 100644
--- a/gnu/packages/commencement.scm
+++ b/gnu/packages/commencement.scm
@@ -3737,6 +3737,15 @@ exec ~a/bin/~a-~a -B~a/lib -Wl,-dynamic-linker -Wl,~a/~a 
\"$@\"~%"
       ("locales" ,glibc-utf8-locales-final))))
 
 (define-public %final-inputs-riscv64
+  ;; This is similar to the added (list gcc "lib") elsewhere in this file, but
+  ;; due to how (%current-system) is re-defined when performing builds with the
+  ;; '--system' flag, %final-inputs is too early in the evaulation pipeline to
+  ;; correctly identify the system for which a derivation will be built. Thus,
+  ;; since (%current-system) is re-determined by (guix build-system gnu) after
+  ;; loading %final-inputs but before taking into account the '--system' flag,
+  ;; the test for (target-riscv64?) needs to be in (guix build-system gnu),
+  ;; with %final-inputs-riscv64 already available at the same time that
+  ;; %final-inputs is available.
   `(("gcc:lib" ,gcc-final "lib")
     ,@%final-inputs))
 



reply via email to

[Prev in Thread] Current Thread [Next in Thread]