04/06: services: qemu-guest-agent: Fix arguments to qemu-ga.

[guix-commits]

civodul pushed a commit to branch master
in repository guix.

commit ee199cd3baf3f2f207223749e0c1015432826bd3
Author: Timotej Lazar <timotej.lazar@araneo.si>
AuthorDate: Thu Jul 28 17:03:25 2022 +0200

    services: qemu-guest-agent: Fix arguments to qemu-ga.
    
    Fix the check for empty device path. Do not use --daemonize, since that is
    handled by make-forkexec-constructor. Drop the --pidfile option which is
    unused without --daemonize.
    
    * gnu/services/virtualization.scm (qemu-guest-agent-shepherd-service): 
Modify
    command arguments.
    
    Signed-off-by: Ludovic Courtès <ludo@gnu.org>
---
 gnu/services/virtualization.scm | 12 +++++-------
 1 file changed, 5 insertions(+), 7 deletions(-)

diff --git a/gnu/services/virtualization.scm b/gnu/services/virtualization.scm
index 41afe451c1..406752b35c 100644
--- a/gnu/services/virtualization.scm
+++ b/gnu/services/virtualization.scm
@@ -879,13 +879,11 @@ specified, the QEMU default path is used."))
       (provision '(qemu-guest-agent))
       (documentation "Run the QEMU guest agent.")
       (start #~(make-forkexec-constructor
-                `(,(string-append #$qemu "/bin/qemu-ga") "--daemon"
-                  "--pidfile=/var/run/qemu-ga.pid"
-                  "--statedir=/var/run"
-                  ,@(if #$device
-                        (list (string-append "--path=" #$device))
-                        '()))
-                #:pid-file "/var/run/qemu-ga.pid"
+                `(,(string-append #$qemu "/bin/qemu-ga")
+                  "--statedir" "/var/run"
+                  ,@(if (string-null? #$device)
+                        '()
+                        (list "--path" #$device)))
                 #:log-file "/var/log/qemu-ga.log"))
       (stop #~(make-kill-destructor))))))