guix-commits
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

01/13: import: hackage: Allow version at the beginning of cabal file.


From: guix-commits
Subject: 01/13: import: hackage: Allow version at the beginning of cabal file.
Date: Sat, 21 Jan 2023 06:55:19 -0500 (EST)

lbraun pushed a commit to branch wip-haskell
in repository guix.

commit 8af6dba7e34026b1a1ef49417a49a382f14f1ed2
Author: Lars-Dominik Braun <lars@6xq.net>
AuthorDate: Sat Jun 11 11:02:52 2022 +0200

    import: hackage: Allow version at the beginning of cabal file.
    
    Fix a corner case, uncovered by the hedgehog package, which has the
    version field at the beginning of its cabal file. This causes a pattern
    match failure.
    
    * guix/import/hackage.scm (latest-release): Match version at beginning
    of expression too.
---
 guix/import/hackage.scm | 5 ++++-
 1 file changed, 4 insertions(+), 1 deletion(-)

diff --git a/guix/import/hackage.scm b/guix/import/hackage.scm
index 7bc2908405..e915aac58d 100644
--- a/guix/import/hackage.scm
+++ b/guix/import/hackage.scm
@@ -378,7 +378,10 @@ respectively."
                "warning: failed to parse ~a~%"
                (hackage-cabal-url hackage-name))
        #f)
-      ((_ *** ("version" (version)))
+      ;; Cabal files have no particular order and while usually the version
+      ;; as somewhere in the middle it can also be at the beginning,
+      ;; requiring two pattern.
+      ((or (_ *** ("version" (version))) (("version" (version)) _ ...))
        (let ((url (hackage-uri hackage-name version)))
          (upstream-source
           (package (package-name package))



reply via email to

[Prev in Thread] Current Thread [Next in Thread]