[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
40/47: gnu: findutils: Move test-strerror_r from XFAIL to skip for the H
From: |
guix-commits |
Subject: |
40/47: gnu: findutils: Move test-strerror_r from XFAIL to skip for the Hurd. |
Date: |
Sat, 3 Jun 2023 07:23:45 -0400 (EDT) |
janneke pushed a commit to branch wip-hurd
in repository guix.
commit 3bdc7283dc9418e67cb248ecdab6166816c3b45c
Author: Janneke Nieuwenhuizen <janneke@gnu.org>
AuthorDate: Fri Jun 2 16:47:36 2023 +0200
gnu: findutils: Move test-strerror_r from XFAIL to skip for the Hurd.
* gnu/packages/base.scm (findutils)[arguments]: When building for the Hurd,
remove #:make-flags as "test-strerror_r" fails non-deterministically.
Instead, add 'skip-test' phase and skip it.
---
gnu/packages/base.scm | 14 ++++++++++----
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/gnu/packages/base.scm b/gnu/packages/base.scm
index e7bfa9e6ef..2c7d6e500b 100644
--- a/gnu/packages/base.scm
+++ b/gnu/packages/base.scm
@@ -339,10 +339,16 @@ interactive means to merge two files.")
(substitute* '("tests/xargs/verbose-quote.sh"
"tests/find/exec-plus-last-file.sh")
(("#!/bin/sh")
- (string-append "#!" (which "sh")))))))
- #:make-flags ,(if (hurd-target?)
- ''("XFAIL_TESTS=test-strerror_r")
- ''())))
+ (string-append "#!" (which "sh"))))))
+ ,@(if (hurd-target?)
+ '((add-after 'unpack 'skip-tests
+ (lambda _
+ (substitute*
+ ;; This test fails non-deterministically
+ "gnulib-tests/test-strerror_r.c"
+ (("main \\(void\\).*" all)
+ (string-append all "{\n exit (77);//"))))))
+ '()))))
(synopsis "Operating on files matching given criteria")
(description
"Findutils supplies the basic file directory searching utilities of the
- 42/47: gnu: gettext-minimal: Remove XFAIL_TESTS for the Hurd., (continued)
- 42/47: gnu: gettext-minimal: Remove XFAIL_TESTS for the Hurd., guix-commits, 2023/06/03
- 01/47: hurd-boot: Add urandom and default-pager translators., guix-commits, 2023/06/03
- 04/47: gnu: hurd: Update supported systems., guix-commits, 2023/06/03
- 07/47: gnu: mig: Update to 04bfe7a91223ba15d868f7165e49328b1c6e86c3., guix-commits, 2023/06/03
- 14/47: gnu: hurd-minimal: Include libshouldbeinlibc and libstore., guix-commits, 2023/06/03
- 19/47: system: hurd: Boot with pci.arbiter and rumpdisk., guix-commits, 2023/06/03
- 31/47: gnu: commencement: hurd-headers-boot0: Update to 0.9.git20230216., guix-commits, 2023/06/03
- 35/47: Revert "gnu: libunistring: Fix make check for the Hurd.", guix-commits, 2023/06/03
- 37/47: gnu: coreutils: Skip hanging and failing test for the Hurd., guix-commits, 2023/06/03
- 39/47: Revert "gnu: sed: Skip failing test on GNU/Hurd.", guix-commits, 2023/06/03
- 40/47: gnu: findutils: Move test-strerror_r from XFAIL to skip for the Hurd.,
guix-commits <=
- 09/47: Revert "hurd-boot: Add urandom and default-pager translators.", guix-commits, 2023/06/03
- 12/47: gnu: hurd: Update libpciaccess to 0.17., guix-commits, 2023/06/03
- 22/47: gnu: netdde: Resurrect and update to 2.6.32.65-2-e67c284ac1., guix-commits, 2023/06/03
- 41/47: gnu: diffutils: Remove test-perror2 from XFAIL_TESTS for the Hurd., guix-commits, 2023/06/03
- 08/47: gnu: hurd: Update to v0.9.git20230216., guix-commits, 2023/06/03
- 32/47: gnu: commencement: hurd-minimal-boot0: Update to 0.9.git20230216., guix-commits, 2023/06/03
- 44/47: hurd-boot: Support system init: Create essential device nodes., guix-commits, 2023/06/03
- 47/47: DRAFT system: examples: Add devel-hurd.tmpl., guix-commits, 2023/06/03
- 43/47: hurd: Support system init in /libexec/runsystem., guix-commits, 2023/06/03
- 45/47: DRAFT hurd: Support second boot., guix-commits, 2023/06/03