Re: [PATCH] Add MPD

[Andreas Enge]

Hello,

On Sun, Feb 23, 2014 at 06:34:07PM -0500, David Thompson wrote:
> Attached is a patch with basic package recipes for libmpdclient and MPD.
> MPD has a lot of optional dependencies and I've included as inputs all
> of the ones that Guix currently has packages for.  libmpdclient requires
> doxygen in order to generate documentation and since Guix does not have
> a package for this yet I've disabled the documentation for now.

the approach looks good. I think I would prepare two separate patches,
adding the packages one by one. And I would prepend the comment "Needs
doxygen" by "FIXME", so we know there is a TODO item.

If you feel like it, you can also add in comment a list of all the optional
inputs, so that it will be easier to add them once they are available (see
ffmpeg for an example).

Andreas