Re: [PATCH] gnu: Add unixodbs

[David Thompson]

Typo in the subject line: s/unixodbs/unixodbc/

John Darrington <address@hidden> writes:

> * gnu/packages/databases.scm (unixodbc): New variable.
> ---
>  gnu/packages/databases.scm |   23 ++++++++++++++++++++++-
>  1 file changed, 22 insertions(+), 1 deletion(-)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index a9ddef6..e9b2f9e 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -35,7 +35,7 @@
>    #:use-module (gnu packages gnupg)
>    #:use-module (gnu packages python)
>    #:use-module ((guix licenses)
> -                #:select (gpl2 gpl3+ lgpl3+ x11-style bsd-style
> +                #:select (gpl2 gpl3+ lgpl2.1+ lgpl3+ x11-style bsd-style
>                            public-domain))
>    #:use-module (guix packages)
>    #:use-module (guix download)
> @@ -323,3 +323,24 @@ capable RDBMS working for your Perl project you simply 
> have to install this
>  module, and nothing else.")
>      (license (package-license perl))
>      (home-page 
> "http://search.cpan.org/~ishigaki/DBD-SQLite/lib/DBD/SQLite.pm";)))
> +
> +
> +(define-public unixodbc
> +  (package
> +   (name "unixodbc")
> +   (version "2.3.2")
> +   (source (origin
> +            (method url-fetch)
> +            (uri 
> +             (string-append
> +              "ftp://ftp.unixodbc.org/pub/unixODBC/unixODBC-"; version 
> ".tar.gz"))
> +            (sha256
> +             (base32 
> "16jw5fq7wgfky6ak1h2j2pqx99jivsdl4q8aq6immpr55xs5jd4w"))))
> +   (build-system gnu-build-system)
> +   (synopsis "Data source abstraction library")
> +   (description "Unixodbc is a library providing a
> +API with which to access Data Sources. Data Sources include SQL
> +Servers and any Data Source with an ODBC Driver.")

This paragraph doesn't look wrapped properly.  Also 'an API' not 'a
API'.  I don't think 'Data Sources' needs to be capitalized like that.

> +   (license lgpl2.1+) 
> +   ;; COPYING contains copy of lgpl2.1 - but copyright notices just say 
> "LGPL"
> +   (home-page "http://www.unixodbc.org";)))
> -- 
> 1.7.10.4
>
>

Looks good to me, minus those few nitpicks. :)

-- 
David Thompson
Web Developer - Free Software Foundation - http://fsf.org
GPG Key: 0FF1D807
Support the FSF: https://fsf.org/donate