Re: [PATCH] gnu: Add ruby 1.8.7

[Mark H Weaver]

Pjotr Prins <address@hidden> writes:

> On Sun, Oct 26, 2014 at 09:43:22PM -0400, Mark H Weaver wrote:
>> In broad strokes, we use the GNU changelog conventions:
>> 
>>   http://www.gnu.org/prep/standards/html_node/Change-Logs.html
>> 
>> but with some minor formatting differences.  However, the best thing is
>> to look in the commit history for examples close to what you're doing.
>> 
>> There is brief mention of this in the "Submitting Patches" section of
>> the HACKING file in the source tree.
>
> I read those earlier. I used a commit message we used before. I think
> that if you are serious about convention you should point to a real
> list of allowed standard messages.

The commit log is full of examples, but I agree that it would be good to
have more documentation on this.  There's a lot to do, and we're a small
team.

> Now it looks arbitrary and makes the submitter look stupid.

I agree that the conventions are arbitrary, and could probably use
improvement, but I also think there's some value in keeping things
consistent.  I don't think it makes you look stupid.  I'm sorry if I
came off that way.

>> >> It looks like the 'native-search-paths' field needs to be overridden,
>> >> since the existing one has "2.1.3" in it.
>> >
>> > I don't think it is used by 1.8.7. Does that matter?
>> 
>> Yes, otherwise users who install ruby 1.8.7 will be advised to set
>> GEM_PATH to $HOME/.guix-profile/lib/ruby/gems/2.1.3.
>
> Ah, that is what it is for. Actually the build did not give me that
> message.

The message is supposed to be shown when you install the package using
"guix package -i", but I see that it wasn't working.  The reason is that
"lib/ruby/gems/2.1.3" doesn't actually exist in the built ruby package.
Instead, there's "lib/ruby/gems/2.1.0".  I guess that should be fixed in
a separate commit.

If the search-path-specification contains a directory that exists and is
not already in your GEM_PATH, you should see the message when you
install ruby, or when you run "guix package --search-paths".

> I DO get a load of messages such as
>
>   
> strip:/gnu/store/icz59y35qqmm4jcrnkqx7d73xlzsq0lq-ruby-1.8.7-p374/lib/ruby/1.8/rexml/attlistdecl.rb:
>   File format not recognized
>
> is there a way to prevent files with a .rb extension or ruby shebang
> to be stripped?

In theory the default 'strip' phase could be replaced by one that's more
selective, but please don't do that.

The problem happens in almost every package, so the improvements should
be made in the default 'strip' phase.  The relevant procedure is 'strip'
in guix/build/gnu-build-system.scm, but beware that changing that file
(or just about anything else in that directory) will trigger a full
rebuild of all packages.  It would be nice to do at some point, but it's
quite far down on our TODO list.

     Regards,
       Mark