Re: [PATCH] gnu: Add ngircd.

[Mark H Weaver]

address@hidden (Taylan Ulrich "Bayırlı/Kammer") writes:

> From 444dc72eff46ceb343fcdfdfc368390417201002 Mon Sep 17 00:00:00 2001
> From: =?UTF-8?q?Taylan=20Ulrich=20Bay=C4=B1rl=C4=B1/Kammer?=
>  <address@hidden>
> Date: Sat, 31 Jan 2015 22:03:25 +0100
> Subject: [PATCH] gnu: Add ngircd.
>
> * gnu-system.am (GNU_SYSTEM_MODULES): Add ngircd.scm.
> * gnu/packages/ngircd.scm: New file.
> ---
>  gnu-system.am           |  1 +
>  gnu/packages/ngircd.scm | 61 
> +++++++++++++++++++++++++++++++++++++++++++++++++
>  2 files changed, 62 insertions(+)
>  create mode 100644 gnu/packages/ngircd.scm

How about adding this package to messaging.scm instead?

> diff --git a/gnu/packages/ngircd.scm b/gnu/packages/ngircd.scm
> new file mode 100644
> index 0000000..4636df5
> --- /dev/null
> +++ b/gnu/packages/ngircd.scm
> @@ -0,0 +1,61 @@
> +;;; GNU Guix --- Functional package management for GNU
> +;;; Copyright © 2014 Taylan Ulrich Bayırlı/Kammer <address@hidden>

It's 2015 :)

> +;;;
> +;;; This file is part of GNU Guix.
> +;;;
> +;;; GNU Guix is free software; you can redistribute it and/or modify it
> +;;; under the terms of the GNU General Public License as published by
> +;;; the Free Software Foundation; either version 3 of the License, or (at
> +;;; your option) any later version.
> +;;;
> +;;; GNU Guix is distributed in the hope that it will be useful, but
> +;;; WITHOUT ANY WARRANTY; without even the implied warranty of
> +;;; MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
> +;;; GNU General Public License for more details.
> +;;;
> +;;; You should have received a copy of the GNU General Public License
> +;;; along with GNU Guix.  If not, see <http://www.gnu.org/licenses/>.
> +
> +(define-module (gnu packages ngircd)
> +  #:use-module ((guix licenses) #:prefix l:)
> +  #:use-module (guix packages)
> +  #:use-module (guix download)
> +  #:use-module (guix build-system gnu)
> +  #:use-module (gnu packages gnutls)
> +  #:use-module (gnu packages compression))
> +
> +(define-public ngircd
> +  (package
> +    (name "ngircd")
> +    (version "22")
> +    (source (origin
> +              (method url-fetch)
> +              (uri (string-append 
> "http://arthur.barton.de/pub/ngircd/ngircd-";
> +                                  version ".tar.xz"))
> +              (sha256
> +               (base32
> +                "17k3g9qd9d010czk5846qxvzkmw4fihv8l6m2a2287crbxm3xhd4"))))
> +    (build-system gnu-build-system)
> +    ;; XXX Add more inputs to enable more features, e.g. IDENT, libiconv.
> +    (inputs `(("zlib" ,zlib)
> +              ("gnutls" ,gnutls)))
> +    (arguments
> +     `(#:configure-flags
> +       `("--with-gnutls" "--enable-ipv6")
> +       #:phases
> +       ;; Necessary for the test suite, should it be enabled in the future.
> +       (alist-cons-after
> +        'configure 'post-configure
> +        (lambda _
> +          (substitute* "src/ngircd/Makefile"
> +            (("#!/bin/sh") (which "sh"))))

This substitution will remove the "#!", which we want to keep.

> +        %standard-phases)
> +       ;; Test-suite inflates our dependencies with e.g. expect(1).
> +       #:tests? #f))

I think it would be good to enable the test suite if possible.  Adding
'expect' as an input is not a problem.  Can you try it and see if you
run into other serious difficulties?

> +    (home-page "http://ngircd.barton.de/";)
> +    (synopsis "Lightweight Internet Relay Chat server for small networks")
> +    (description
> +     "ngIRCd is a lightweight Internet Relay Chat server for small or private
> +networks.  It is easy to configure, can cope with dynamic IP addresses, and
> +supports IPv6, SSL-protected connections as well as PAM for authentication.")
> +    (license l:gpl2+)))

Otherwise looks good to me.  Can you send an updated patch?

     Thanks!
       Mark