[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add GnuCash.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH] Add GnuCash. |
Date: |
Wed, 06 May 2015 10:58:03 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
> From a2ea83cfe3fab5101388870626c323191200c066 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 6 May 2015 08:38:06 +0200
> Subject: [PATCH 1/2] gnu: Add WebkitGTK 2.4.8.
>
> * gnu/packages/webkit.scm (webkitgtk-2.4): New variable.
> * gnu/packages/patches/webkitgtk-2.4.8-gmutexlocker.patch: New file.
> * gnu-system.am (dist_patch_DATA): Add it.
[...]
> +++ b/gnu/packages/patches/webkitgtk-2.4.8-gmutexlocker.patch
> @@ -0,0 +1,284 @@
> +Webkit's own WebCore::GMutexLocker conflicts with the GMutexLocker in
> +glib-2.44.0.
[...]
> + ;; Patch taken from <http://pkgs.fedoraproject.org/cgit/
> + ;; webkitgtk3.git/plain/webkitgtk-2.4.8-gmutexlocker.patch
> + ;; ?id=7433f334cc84866af5ef0b2c25ead931e6e603ea>
> + (patches (list (search-patch
> "webkitgtk-2.4.8-gmutexlocker.patch")))))
Please move this comment to the beginning of the .patch file.
Otherwise OK.
> From 23ff763f1492f0e5694ed514b888410df7620c2c Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Wed, 6 May 2015 08:41:40 +0200
> Subject: [PATCH 2/2] gnu: Add GnuCash.
>
> * gnu/packages/gnucash.scm: New file.
> * gnu-system.am (GNU_SYSTEM_MODULES): Add it.
[...]
> + (inputs
> + `(("guile" ,guile-2.0)
> + ("intltool" ,intltool)
> + ("icu4c" ,icu4c)
> + ("glib" ,glib)
> + ("glib" ,glib "bin") ; glib-compile-schemas, etc.
intltool and glib:bin should be native inputs.
OK to push with this change!
Ludo’.