[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH]: gnu: shogun: Remove non-free source files.
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH]: gnu: shogun: Remove non-free source files. |
Date: |
Fri, 15 May 2015 18:56:12 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Ricardo Wurmus <address@hidden> skribis:
>>>>> There are functions in src/shogun/kernel/Kernel.{cpp,h} that are also
>>>>> released under non-free terms, but they are enclosed in #ifdef
>>>>> statements and the make flags we pass disable these functions at build
>>>>> time.
>>>>
>>>> This is not sufficient. We will need to completely remove the non-free
>>>> functions from the source code using a snippet. We cannot use a patch
>>>> because the patch would contain the non-free code.
>
> Just a quick update: I've added snippets to remove all non-free stuff
> and it's compiling (after I applied a patch to R 3.2.0 which I will send
> to the ML later).
Great.
> Sadly, the RUNPATH validation is failing, so I first need to find some
> time to fix this. Would you like me to submit the patch to remove the
> non-free parts first even though the RUNPATH validation is still
> failing, or would you like me to submit this all at once instead?
If the two are unrelated, feel free to commit the snippets already.
Thanks,
Ludo’.
- [PATCH]: gnu: shogun: Remove non-free source files., Ricardo Wurmus, 2015/05/08
- Re: [PATCH]: gnu: shogun: Remove non-free source files., Ludovic Courtès, 2015/05/08
- Re: [PATCH]: gnu: shogun: Remove non-free source files., Mark H Weaver, 2015/05/09
- Re: [PATCH]: gnu: shogun: Remove non-free source files., Ludovic Courtès, 2015/05/09
- Re: [PATCH]: gnu: shogun: Remove non-free source files., Mark H Weaver, 2015/05/09
- Re: [PATCH]: gnu: shogun: Remove non-free source files., Ricardo Wurmus, 2015/05/15
- Re: [PATCH]: gnu: shogun: Remove non-free source files.,
Ludovic Courtès <=
- Re: [PATCH]: gnu: shogun: Remove non-free source files., Ricardo Wurmus, 2015/05/21
- Re: [PATCH]: gnu: shogun: Remove non-free source files., Ludovic Courtès, 2015/05/21
- Re: [PATCH]: gnu: shogun: Remove non-free source files., Ludovic Courtès, 2015/05/21
- Re: [PATCH]: gnu: shogun: Remove non-free source files., Ricardo Wurmus, 2015/05/09