[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add guile-emacs!
From: |
Taylan Ulrich Bayırlı/Kammer |
Subject: |
Re: [PATCH] Add guile-emacs! |
Date: |
Tue, 19 May 2015 20:29:34 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Christopher Allan Webber <address@hidden> writes:
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ,@(package-native-inputs emacs)))
> + (inputs
> + `(("guile" ,guile-for-guile-emacs)
> + ,@(package-inputs emacs)))
I didn't think about this before: if Guile is used at compile-time,
e.g. to compile any .scm or .el files, then it should be in native
inputs too. Can you verify whether it's used or not? (In the future it
probably will be used to compile .el files, but that's still not enabled
if I remember correctly.)
> + (arguments
> + (substitute-keyword-arguments `(;; Build fails if we allow parallel
> build
> + #:parallel-build? #f
Stylistic nitpick: sentence in comment should end with a period.
> + (native-inputs
> + `(("autoconf" ,autoconf)
> + ("automake" ,automake)
> + ("libtool" ,libtool)
> + ("flex" ,flex)
> + ("texinfo" ,texinfo)
> + ,@(package-native-inputs guile-2.0)))
> + (inputs
> + `(("gettext" ,gnu-gettext)
> + ,@(package-inputs guile-2.0)))))
I think we wanted to put Gettext in native-inputs?
I'd say OK to push with those changes, thanks! :-)
Taylan
- [PATCH] Attempt at packaging guile-emacs (needs help), Christopher Allan Webber, 2015/05/10
- Re: [PATCH] Attempt at packaging guile-emacs (needs help), Mark H Weaver, 2015/05/10
- [PATCH] Add guile-emacs!, Christopher Allan Webber, 2015/05/13
- Re: [PATCH] Add guile-emacs!, Christopher Allan Webber, 2015/05/19
- Re: [PATCH] Add guile-emacs!,
Taylan Ulrich Bayırlı/Kammer <=
- Re: [PATCH] Add guile-emacs!, Christopher Allan Webber, 2015/05/19
- Re: [PATCH] Add guile-emacs!, Taylan Ulrich Bayırlı/Kammer, 2015/05/19
- Re: [PATCH] Add guile-emacs!, Ludovic Courtès, 2015/05/20
Re: [PATCH] Add guile-emacs!, Feng Shu, 2015/05/23