[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCHES] Add ruby-rspec, bundler, and ruby-useragent
From: |
Ludovic Courtès |
Subject: |
Re: [PATCHES] Add ruby-rspec, bundler, and ruby-useragent |
Date: |
Fri, 29 May 2015 23:07:42 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
David Thompson <address@hidden> skribis:
> 'git send-email' isn't working for me on GuixSD, so below are 6 patches
> for adding some new Ruby packages. Sorry for the unideal email
> workflow.
ISTR that 宋文武 has a trick to “make it work.” 宋文武?
> From c077e0fa5d4a42748ad4e282c413e24ced124dcc Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Wed, 27 May 2015 21:33:17 -0400
> Subject: [PATCH 1/6] gnu: Add ruby-rspec-core.
>
> * gnu/packages/ruby.scm (ruby-rspec-support, ruby-rspec-core): New variables.
[...]
> +;; RSpec is the dominant testing library for Ruby projects. Even RSpec's
> +;; dependencies use RSpec for their test suites! To avoid these circular
> +;; dependencies, we disable tests for all of the RSpec-related packages.
Heh, makes sense.
OK.
> From 8218ac9aa4a7134d9f2f19ae3ff16a1f40989136 Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Wed, 27 May 2015 21:34:47 -0400
> Subject: [PATCH 2/6] gnu: Add ruby-rspec-expectations.
>
> * gnu/packages/ruby.scm (ruby-diff-lcs-for-rspec, ruby-rspec-expectations):
> New variables.
OK.
> From 23771fa86be95cbb1c6ac66fd22a26705d1b6d0e Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Wed, 27 May 2015 21:35:43 -0400
> Subject: [PATCH 3/6] gnu: Add ruby-rspec-mocks.
>
> * gnu/packages/ruby.scm (ruby-rspec-mocks): New variable.
OK.
> From 6bfb4946d819e9771ac1fa5879f01f3362dfcee6 Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Wed, 27 May 2015 21:36:24 -0400
> Subject: [PATCH 4/6] gnu: Add ruby-rspec.
>
> * gnu/packages/ruby.scm (ruby-rspec): New variable.
OK.
> From 2cc36edb761976fcd4c2a5f5c076fc2d12512cbd Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Wed, 27 May 2015 21:37:06 -0400
> Subject: [PATCH 5/6] gnu: Add bundler.
>
> * gnu/packages/ruby.scm (bundler): New variable.
OK.
> +;; Bundler is yet another source of circular dependencies, so we must disable
> +;; its test suite as well.
Is it also because its dependencies depend on it?
> From 7d1eb9189646aa9e206c5f6e8c4a4151ad727072 Mon Sep 17 00:00:00 2001
> From: David Thompson <address@hidden>
> Date: Wed, 27 May 2015 21:38:28 -0400
> Subject: [PATCH 6/6] gnu: Add ruby-useragent.
>
Missing log. Otherwise LGTM.
Thanks!
Ludo’.
- [PATCHES] Add ruby-rspec, bundler, and ruby-useragent, David Thompson, 2015/05/27
- Re: [PATCHES] Add ruby-rspec, bundler, and ruby-useragent,
Ludovic Courtès <=
- Re: [PATCHES] Add ruby-rspec, bundler, and ruby-useragent, Thompson, David, 2015/05/29
- Re: [PATCHES] Add ruby-rspec, bundler, and ruby-useragent, Pjotr Prins, 2015/05/30
- Re: [PATCHES] Add ruby-rspec, bundler, and ruby-useragent, Thompson, David, 2015/05/30
- Re: [PATCHES] Add ruby-rspec, bundler, and ruby-useragent, Pjotr Prins, 2015/05/30