Re: [PATCH] Add Faust and Guitarix.

[Ludovic Courtès]

Ricardo Wurmus <address@hidden> skribis:

> From 7d0f4d6702cf6ed370e534862244fb65c414f46d Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Sun, 14 Jun 2015 15:00:37 +0200
> Subject: [PATCH 1/3] gnu: Add Faust.
>
> * gnu/packages/audio.scm (faust): New variable.

[...]

> +          'unpack 'remove-prebuilt-library
> +          (lambda _
> +            (delete-file 
> "architecture/android/libs/armeabi-v7a/libfaust_dsp.so")

This should go in a snippet IMO.

Otherwise OK.

> From 790dba434e51ded7e5fe791b7577886f011b00a9 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Sun, 14 Jun 2015 15:01:08 +0200
> Subject: [PATCH 2/3] gnu: Add zita-resampler.
>
> * gnu/packages/audio.scm (zita-resampler): New variable.

OK.

> From eecb83dd2a9ad9faf5016a6381c7fb2072b51aa1 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Sun, 14 Jun 2015 17:15:08 +0200
> Subject: [PATCH 3/3] gnu: Add Guitarix.
>
> * gnu/packages/audio.scm (guitarix): New variable.

[...]

> +        ;; dsp2cc fails for src/faust/tonestack_engl.dsp, so we use the
> +        ;; generated C++ files rather than compiling them from Faust sources.
> +        "--no-faust"

I think it deserves a FIXME.  (It’s OK for now, but the eventual goal
should be to build those from source as well.)

> +    (native-search-paths
> +     (list (search-path-specification
> +            (variable "LV2_PATH")
> +            (files '("lib/lv2")))))

Shouldn’t it be in LV2 itself instead?

> +    (home-page "http://guitarix.org/";)
> +    (synopsis "Virtual guitar amplifier")
> +    (description "Guitarix is a virtual guitar amplifier running JACK.")

Could you expound a bit, for instance using the second paragraph on the
web page?

(And then make sure to have the GuixSD logo listed next to Debian et
al. in their “Install” section.  ;-))

Thank you, and happy guitar playing!  :-)

Ludo’.