Re: [PATCH] gnu: Add ruby 1.8.7 package

[Thompson, David]

On Tue, Jun 16, 2015 at 11:46 AM, Pjotr Prins <address@hidden> wrote:
> Anything wrong with this patch?
>
> On Sun, Jun 14, 2015 at 10:36:40AM +0200, Pjotr Prins wrote:
>> From be945cf4d65ab77eb8bd7a462aa0b7d24877ba74 Mon Sep 17 00:00:00 2001
>> From: pjotrp <address@hidden>
>> Date: Sat, 13 Jun 2015 13:22:10 +0200
>> Subject: [PATCH] gnu: Add ruby 2.1.6
>>
>> * gnu/packages/ruby.scm (ruby-2.1): New variable.
>> ---
>>  gnu/packages/ruby.scm |   28 ++++++++++++++++++++++++++++
>>  1 file changed, 28 insertions(+)
>>
>> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
>> index 9943de7..f0c645e 100644
>> --- a/gnu/packages/ruby.scm
>> +++ b/gnu/packages/ruby.scm
>> @@ -87,6 +87,34 @@ a focus on simplicity and productivity.")
>>      (home-page "https://ruby-lang.org";)
>>      (license license:ruby)))
>>
>> +(define-public ruby-2.1
>> +  (package (inherit ruby)
>> +    (version "2.1.6")
>> +    (source
>> +     (origin
>> +       (method url-fetch)
>> +       (uri (string-append "http://cache.ruby-lang.org/pub/ruby/";
>> +                           (version-major+minor version)
>> +                           "/ruby-" version ".tar.bz2"))
>> +       (sha256
>> +        (base32
>> +         "1sbcmbhadcxk0509svwxbm2vvgmpf3xjxr1397bgp9x46nz36lkv"))))
>> +    (native-search-paths '())
>> +    (arguments
>> +     `(#:test-target "test"
>> +       #:parallel-tests? #f
>> +       #:phases
>> +        (alist-cons-before
>> +         'configure 'replace-bin-sh
>> +         (lambda _
>> +           (substitute* '("Makefile.in"
>> +                          "ext/pty/pty.c"
>> +                          "io.c"
>> +                          "lib/mkmf.rb"
>> +                          "process.c")
>> +             (("/bin/sh") (which "sh"))))
>> +         %standard-phases)))))
>> +
>>  (define-public ruby-1.8
>>    (package (inherit ruby)
>>      (version "1.8.7-p374")
>> --
>> 1.7.10.4
>>

Sorry for the delay.  The only thing I noticed is that you need to add
the native search paths into this recipe, changing 2.2 to 2.1 in the
path directory.

Could you submit an updated patch?  I will test and merge after.  FYI,
I've begun work on a helper procedure to make it easy to make variants
of gem packages that use a different Ruby.  That patch should come
pretty soon.

- Dave