[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add FastTree
From: |
Mark H Weaver |
Subject: |
Re: [PATCH] Add FastTree |
Date: |
Sat, 20 Jun 2015 13:17:40 -0400 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Hi Ben,
Instead of using 'trivial-build-system' for this, it would be better to
use 'gnu-build-system' and remove/replace the phases that aren't
appropriate. So, you'll probably want to remove the 'configure' phase
and replace the 'build' and 'install' phases.
Even so, there are many important phases and implicit inputs in
'gnu-build-system', notably setting the environment variables before the
build, and checking for missing rpaths in the installed binaries.
As you have it now, since you used bare 'binutils' and not our
'ld-wrapper' package, and you didn't add explicit rpaths options to the
linker, I guess that the produced executable won't be able to find the
specific shared libraries it was linked against without more help.
Mark
- [PATCH] Add FastTree, Ben Woodcroft, 2015/06/19
- Re: [PATCH] Add FastTree, Alex Kost, 2015/06/19
- Re: [PATCH] Add FastTree, Ben Woodcroft, 2015/06/20
- Re: [PATCH] Add FastTree, Ben Woodcroft, 2015/06/20
- Re: [PATCH] Add FastTree,
Mark H Weaver <=
- Re: [PATCH] Add FastTree, Ben Woodcroft, 2015/06/20
- Re: [PATCH] Add FastTree, Mark H Weaver, 2015/06/21
- Re: [PATCH] Add FastTree, Ben Woodcroft, 2015/06/21
- Re: [PATCH] Add FastTree, Mark H Weaver, 2015/06/21