[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/5] import: Add 'elpa' importer
From: |
Ludovic Courtès |
Subject: |
Re: [PATCH 1/5] import: Add 'elpa' importer |
Date: |
Sat, 27 Jun 2015 12:08:51 +0200 |
User-agent: |
Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) |
Federico Beffa <address@hidden> skribis:
> From 56c460213d76ff2b88fd771b48997c3e03200234 Mon Sep 17 00:00:00 2001
> From: Federico Beffa <address@hidden>
> Date: Tue, 16 Jun 2015 10:50:06 +0200
> Subject: [PATCH 1/6] import: Add 'elpa' importer.
>
> * guix/import/elpa.scm: New file.
> * guix/scripts/import.scm: Add "elpa" to 'importers'.
> * guix/scripts/import/elpa.scm: New file.
> * Makefile.am (MODULES): Add 'guix/import/elpa.scm' and
> 'guix/scripts/import/elpa.scm'.
> (SCM_TESTS): Add 'tests/elpa.scm'.
> * doc/guix.texi (Invoking guix import): Document it.
> * tests/elpa.scm: New file.
Please add guix/scripts/import/elpa.scm to po/guix/POTFILES.in (sorry,
I had forgotten about it.)
[...]
> +(define* (call-with-downloaded-file url proc
> + #:optional (err-msg "unavailable"))
> + "Fetch URL, store the content in a temporary file and call PROC with that
> +file. Returns the value returned by PROC."
> + (call-with-temporary-output-file
> + (lambda (temp port)
> + (or (and (url-fetch url temp)
> + (call-with-input-file temp proc))
> + (error err-msg url)))))
Please fix the indentation.
Remove the ‘err-msg’ parameter, and change the ‘error’ call to:
(error "download failed" url)
OK to push with these changes.
Thanks!
Ludo’.