[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] Add builder, rjb, antwrap, orderedhash, xml-simple, thor
From: |
Thompson, David |
Subject: |
Re: [PATCH] Add builder, rjb, antwrap, orderedhash, xml-simple, thor |
Date: |
Fri, 28 Aug 2015 20:45:09 -0400 |
[ Like the last time, apologies if this web-based mail client misbehaves ]
> From 981df1559fab6b77ec9cfc820aa5b77a4fb75475 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 28 Aug 2015 17:24:45 +0200
> Subject: [PATCH 1/6] gnu: Add ruby-builder.
>
> * gnu/packages/ruby.scm (ruby-builder): New variable.
> ---
> gnu/packages/ruby.scm | 28 ++++++++++++++++++++++++++++
> 1 file changed, 28 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 9a702dd..3ee5d31 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -3,6 +3,7 @@
> ;;; Copyright © 2014 Ludovic Courtès <address@hidden>
> ;;; Copyright © 2014, 2015 Mark H Weaver <address@hidden>
> ;;; Copyright © 2014 David Thompson <address@hidden>
> +;;; Copyright © 2015 Ricardo Wurmus <address@hidden>
> ;;;
> ;;; This file is part of GNU Guix.
> ;;;
> @@ -364,6 +365,33 @@ specified in a \"Gemfile\", as well as their
> dependencies.")
> (home-page "http://bundler.io/")
> (license license:expat)))
>
> +(define-public ruby-builder
> + (package
> + (name "ruby-builder")
> + (version "3.2.2")
> + (source (origin
> + (method url-fetch)
> + (uri (rubygems-uri "builder" version))
> + (sha256
> + (base32
> + "14fii7ab8qszrvsvhz6z2z3i4dw0h41a62fjr2h1j8m41vbrmyv2"))))
> + (build-system ruby-build-system)
> + (arguments
> + `(#:phases
> + (modify-phases %standard-phases
> + (add-after
> + 'unpack 'do-not-use-rvm
I know Emacs doesn't indent this right automatically, but it's
preferable to put those two symbols on the previous line. The lambda
below should stay indented as-is.
> + (lambda _
> + (substitute* "rakelib/tags.rake"
> + (("RVM_GEMDIR = .*") "RVM_GEMDIR = 'no-rvm-please'\n"))
> + #t)))))
> + (synopsis "Ruby gem bundler")
You forgot to add a real synopsis.
> + (description "Builder provides a number of builder objects that make it
> +easy to create structured data. Currently the following builder objects are
> +supported: XML Markup and XML Events.")
> + (home-page "https://github.com/jimweirich/builder")
Ah, one of Jim's creations. RIP.
> + (license license:expat)))
> +
> (define-public ruby-useragent
> (package
> (name "ruby-useragent")
> --
> 2.1.0
> From 035be27211cbffe7cf9b66fefc8826ebb0e69aa5 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 28 Aug 2015 17:25:42 +0200
> Subject: [PATCH 2/6] gnu: Add ruby-rjb.
>
> * gnu/packages/ruby.scm (ruby-rjb): New variable.
> ---
> gnu/packages/ruby.scm | 29 +++++++++++++++++++++++++++++
> 1 file changed, 29 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 3ee5d31..38c6367 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -26,6 +26,7 @@
> #:use-module (gnu packages compression)
> #:use-module (gnu packages readline)
> #:use-module (gnu packages autotools)
> + #:use-module (gnu packages java)
> #:use-module (gnu packages libffi)
> #:use-module (gnu packages gdbm)
> #:use-module (gnu packages tls)
> @@ -392,6 +393,34 @@ supported: XML Markup and XML Events.")
> (home-page "https://github.com/jimweirich/builder")
> (license license:expat)))
>
> +(define-public ruby-rjb
> + (package
> + (name "ruby-rjb")
> + (version "1.5.3")
> + (source (origin
> + (method url-fetch)
> + (uri (rubygems-uri "rjb" version))
> + (sha256
> + (base32
> + "0gzs92dagk981s4vrymnqg0vll783b9k564j0cdgp167nc5a2zg4"))))
> + (build-system ruby-build-system)
> + (arguments
> + `(#:tests? #f ; no rakefile
> + #:phases
> + (modify-phases %standard-phases
> + (add-before
> + 'build 'set-java-home
Same style comment as above.
> + (lambda* (#:key inputs #:allow-other-keys)
> + (setenv "JAVA_HOME" (assoc-ref inputs "jdk"))
> + #t)))))
> + (native-inputs
> + `(("jdk" ,icedtea7 "jdk")))
> + (synopsis "Ruby-to-Java bridge using the Java Native Interface")
> + (description "RJB is a bridge program that connects Ruby and Java via the
> +Java Native Interface.")
> + (home-page "http://www.artonx.org/collabo/backyard/?RubyJavaBridge")
> + (license license:lgpl2.1+)))
> +
> (define-public ruby-useragent
> (package
> (name "ruby-useragent")
> --
> 2.1.0
> From 26a833352b201dce452423524804d2e3253b3343 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 28 Aug 2015 17:26:07 +0200
> Subject: [PATCH 3/6] gnu: Add ruby-atoulme-antwrap.
>
> * gnu/packages/ruby.scm (ruby-atoulme-antwrap): New variable.
LGTM.
> From a85b8ef75e9f20b923f156d8d499e450f5d04433 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 28 Aug 2015 17:26:35 +0200
> Subject: [PATCH 4/6] gnu: Add ruby-orderedhash.
>
> * gnu/packages/ruby.scm (ruby-orderedhash): New variable.
LGTM.
> From f49f42d5aaec4ab3fdf9031dd9fc33c36f230460 Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 28 Aug 2015 17:21:48 +0200
> Subject: [PATCH 5/6] gnu: Add ruby-xml-simple.
>
> * gnu/packages/ruby.scm (ruby-xml-simple): New variable.
> ---
> gnu/packages/ruby.scm | 19 +++++++++++++++++++
> 1 file changed, 19 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 7f8b4c6..6009d8c 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -465,6 +465,25 @@ extensions.")
> (home-page "http://codeforpeople.com/lib/ruby/orderedhash/")
> (license license:public-domain)))
>
> +(define-public ruby-xml-simple
> + (package
> + (name "ruby-xml-simple")
> + (version "1.1.5")
> + (source (origin
> + (method url-fetch)
> + (uri (rubygems-uri "xml-simple" version))
> + (sha256
> + (base32
> + "0xlqplda3fix5pcykzsyzwgnbamb3qrqkgbrhhfz2a2fxhrkvhw8"))))
> + (build-system ruby-build-system)
> + (arguments
> + '(#:tests? #f)) ; no test suite
> + (synopsis "Simple Ruby library for XML processing")
> + (description "This library provides a simple API for XML processing in
> +Ruby.")
> + (home-page "https://github.com/maik/xml-simple")
> + (license (package-license ruby))))
Why not just 'license:ruby'?
> +
> (define-public ruby-useragent
> (package
> (name "ruby-useragent")
> --
> 2.1.0
> From b94a7147ce1c46aecfcb25426d614fbd8b6c04ec Mon Sep 17 00:00:00 2001
> From: Ricardo Wurmus <address@hidden>
> Date: Fri, 28 Aug 2015 17:22:28 +0200
> Subject: [PATCH 6/6] gnu: Add ruby-thor.
>
> * gnu/packages/ruby.scm (ruby-thor): New variable.
LGTM.
Thank you for all these shiny new Ruby packages. I'm happy that the
new build system worked well for all of them. I hope these help you
get closer to sanity with regards to getting Maven packaged.
- Dave
- [PATCH] Add rake., Ricardo Wurmus, 2015/08/28
- Re: [PATCH] Add rake., Thompson, David, 2015/08/28
- [PATCH] Add builder, rjb, antwrap, orderedhash, xml-simple, thor, Ricardo Wurmus, 2015/08/28
- Re: [PATCH] Add builder, rjb, antwrap, orderedhash, xml-simple, thor,
Thompson, David <=