Re: [PATCH 1/2] gnu: Add ruby-docile.

[Thompson, David]

On Wed, Sep 16, 2015 at 12:06 AM, Pjotr Prins <address@hidden> wrote:
> * gnu/packages/ruby.scm (ruby-docile): New variable.
> ---
>  gnu/packages/ruby.scm | 23 +++++++++++++++++++++++
>  1 file changed, 23 insertions(+)
>
> diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm
> index 7dc46b6..539b00b 100644
> --- a/gnu/packages/ruby.scm
> +++ b/gnu/packages/ruby.scm
> @@ -1125,6 +1125,28 @@ into a single method call.")
>      (home-page "http://rack.github.io/";)
>      (license license:expat)))
>
> +(define-public ruby-docile
> +  (package
> +    (name "ruby-docile")
> +    (version "1.1.5")
> +    (source
> +      (origin
> +        (method url-fetch)
> +        (uri (rubygems-uri "docile" version))
> +        (sha256
> +          (base32
> +            "0m8j31whq7bm5ljgmsrlfkiqvacrw6iz9wq10r3gwrv5785y8gjx"))))
> +    (build-system ruby-build-system)
> +    (arguments
> +     '(#:tests? #f)) ; needs github-markup, among others
> +    (synopsis "Docile turns any Ruby object into a DSL")
> +    (description "Turn any Ruby object into a DSL.  Especially useful
> +with the Builder pattern.  Docile is a small, self-contained Ruby
> +library, that let's you map a DSL (domain specific language) to your
> +Ruby objects in a snap.")

A lot of times, the upstream description of software reads like an
advertisement or doesn't well define their terms, so we need to come
up with an appropriate description ourselves.  I changed the synopsis
and description as follows:

    (synopsis "Ruby EDSL helper library")
    (description "Docile is a Ruby library that provides an interface for
creating embedded domain specific languages (EDSLs) that manipulate existing
Ruby classes.")


> +    (home-page "https://ms-ati.github.io/docile/";)
> +    (license license:expat)))
> +
>  (define-public ruby-gherkin3
>    (package
>      (name "ruby-gherkin3")
> @@ -1147,3 +1169,4 @@ It is intended to replace Gherkin 2 and be used by all 
> Cucumber
>  implementations to parse '.feature' files.")
>      (home-page "https://github.com/cucumber/gherkin3";)
>      (license license:expat)))
> +

I removed this extraneous whitespace change.

> --
> 2.4.3
>
>

Pushed.  Thanks.

- Dave