Re: [PATCH] Add MARS shooter.

[Thompson, David]

On Sat, Sep 19, 2015 at 4:25 AM, Ricardo Wurmus <address@hidden> wrote:
> Hi again,
>
>> attached is a patch to add MARS.  This is really a fun game and you can
>> play it with a friend on the same machine.
>
> Eric Bavier told me on IRC that there is actually a tarball I could use
> instead of the git reference, so I tried it:
>
>     $ guix download 
> https://github.com/downloads/thelaui/M.A.R.S./mars_source_0.7.5.tar.gz
>     starting download of `/tmp/guix-file.674jSo' from 
> `https://github.com/downloads/thelaui/M.A.R.S./mars_source_0.7.5.tar.gz'...
>     following redirection to 
> `https://cloud.github.com/downloads/thelaui/M.A.R.S./mars_source_0.7.5.tar.gz'...
>     ERROR: Bad media-type header component: .gz
>
>     failed to download "/tmp/guix-file.674jSo" from 
> "https://github.com/downloads/thelaui/M.A.R.S./mars_source_0.7.5.tar.gz";
>     guix download: error: 
> https://github.com/downloads/thelaui/M.A.R.S./mars_source_0.7.5.tar.gz: 
> download failed
>
> “wget --server-response” tells me that these are the headers:
>
> ~~~~~~
> ...
> Location: 
> https://cloud.github.com/downloads/thelaui/M.A.R.S./mars_source_0.7.5.tar.gz 
> [following]
> --2015-09-19 10:21:18--  
> https://cloud.github.com/downloads/thelaui/M.A.R.S./mars_source_0.7.5.tar.gz
> Resolving cloud.github.com (cloud.github.com)... 54.230.44.22, 54.230.44.124, 
> 54.230.44.114, ...
> Connecting to cloud.github.com (cloud.github.com)|54.230.44.22|:443... 
> connected.
> HTTP request sent, awaiting response...
>   HTTP/1.1 200 OK
>   Content-Type: .gz
>   Content-Length: 86856256
>   Connection: keep-alive
>   Date: Sat, 19 Sep 2015 08:21:20 GMT
>   Last-Modified: Fri, 29 Jun 2012 16:04:12 GMT
>   ETag: "bbbc5fda27ce7f35a0660269c11e93d6"
>   Accept-Ranges: bytes
>   Server: AmazonS3
>   X-Cache: Miss from cloudfront
>   Via: 1.1 d2fa707728d9947a31db9f8dc3e9e56c.cloudfront.net (CloudFront)
>   X-Amz-Cf-Id: HSTrtLUzjdqLxCh9_ZoNDe5WGkZcCF7-gs9mGYBYe32i3ADvttP9gA==
> ~~~~~~
>
> “Content-Type: .gz” is what trips up “guix download”.  What follows
> “Content-Type:” should be a mime type and I suppose “.gz” is not a valid
> mime type.  Would it make sense for the HTTP client to be a little more
> tolerant about this?

No, upstream needs to fix their invalid Content-Type header.  We've
had this problem a few times, most recently with rubygems.org, and in
all cases we've gotten upstream to fix it.  Strict header parsing can
seem like an issue at times, but it's really a very good feature that
the rest of the world seems to ignore. [0]

Hope this helps.  MARS looks fun.  On the subject of games, we should
get more games that can be played over the network and make a little
Guix gaming club.  Xonotic is my #1 request.

[0] https://www.gnu.org/software/guile/manual/html_node/Types-and-the-Web.html