Re: [PATCH] Add Blender

[Ricardo Wurmus]

Eric Bavier <address@hidden> writes:

>> +(define-public openimageio
>> +  (package
> [...]
>> +    (description
>> +      "OpenImageIO is a library for reading and writing images, and a bunch 
>> of
>         ^
> Align the opening quote to the 'd'.

Ah, good catch!  I fixed this and pushed openimageio.

>> * gnu/packages/graphics.scm (blender): New variable.

[...]

>> +         (add-after 'set-paths 'add-ilmbase-include-path
>> +          (lambda* (#:key inputs #:allow-other-keys)
>> +            ;; OpenEXR propagates ilmbase, but its include files do not 
>> appear
>> +            ;; in the CPATH, so we need to add "$ilmbase/include/OpenEXR/" 
>> to
>> +            ;; the CPATH to satisfy the dependency on "half.h".
>> +            (setenv "CPATH"
>> +                    (string-append (assoc-ref inputs "ilmbase")
>> +                                   "/include/OpenEXR"
>> +                                   ":" (getenv "CPATH")))
>
> Is the "half.h" header in OpenEXR, or in blender?  If the latter, would
> it make more sense to instead patch the include directive to include
> the OpenEXR path?

“half.h” is provided by “ilmbase”.  The include is in Blender, in this
file:

    blender-2.75a/source/blender/imbuf/intern/openexr/openexr_api.cpp

I could patch this instead, replacing

    #include <half.h>

with

    #include <OpenEXR/half.h>

I’ll fix this, recompile and if there are no further objections push
upon success.

Thanks!

~~ Ricardo