Re: [PATCH] gnu: Add python-xlrd.

[Ludovic Courtès]

Ben Woodcroft <address@hidden> skribis:

> On 20/09/15 06:37, Mathieu Lirzin wrote:
>> Ricardo Wurmus <address@hidden> writes:
>>
>>> Mathieu Lirzin <address@hidden> writes:
>>>
>>>>> +         ;; so use nose to run tests instead for now.
>>>>> +         (replace 'check (lambda _ (zero? (system* "nosetests")))))))
>>>>> +    (native-inputs
>>>>> +     `(("python-setuptools" ,python2-setuptools)
>>>>> +       ("python-nose" ,python2-nose)))
>>>> I don't know python packaging but when I look at other packages it
>>>> seems that these are usually used as “inputs” not
>>>> “native-inputs”.
>>> Nose is used for the tests only and setuptools is used at build time, so
>>> I think it’s fine like this.
>> Is this a general statement or something specific to this package? If
>> this is general it seems to be a good idea to make a big commit that
>> fixes all the python packages which use these dependencies as normal
>> inputs?  WDYT?
> If someone were to change things wholesale, it might also be a good
> idea to change the pypi importer to match.
>
> Let me know when you want me to send an updated patch - all your
> comments look good to me Marthieu.

Mathieu, Ricardo: It seems to me that this patch should go in.  The
other issues can be discussed separately IMO; WDYT?

Ludo’.