Re: [PATCH 2/2] gnu: Add manaplus.

[Ludovic Courtès]

"Thompson, David" <address@hidden> skribis:

> On Fri, Oct 9, 2015 at 8:40 AM, Ludovic Courtès <address@hidden> wrote:
>> Alex Kost <address@hidden> skribis:
>>
>>> I don't know if there is a better workaround for the SDL headers, but
>>> this problem is rather common: there is a workaround in 'abbaye' and a
>>> special patch for 'pingus'.
>>>
>>> The problem is: the source code has lines like this:
>>>
>>>   #include <SDL_mixer.h>
>>>
>>> but the headers of all SDL packages are placed in “include/SDL/”
>>> subdirectories.  And an upstream often doesn't use "pkg-config" for
>>> every SDL package to define CFLAGS and assumes that all SDL headers are
>>> placed in one directory.  So we have to invent workarounds for such
>>> packages.
>>>
>>> I just mention this problem here, perhaps someone will come up with a
>>> general solution.
>>
>> Can’t ‘sdl-union’ be used here?  I think it was created specifically to
>> solve this problem.  (Currently it’s private to (gnu packages sdl) but
>> you can export it.)
>
> Do you have any concerns about this package being picked up by UIs now
> that it will be public?  Might confuse a user or two, dunno.

No opinion.  If you think we’d rather keep it hidden, we can wrap it in
a thunk for instance so that the UIs don’t pick it up.  WDYT?

Ludo’.