Re: [PATCH 03/43] gnu: xmonad: Patch to work on new Haskell Platform

[Paul van der Walt]

On 2015-10-19 at 15:36, quoth Eric Bavier:
>> +       ("xmonad-cabal-patch"
>> +        ,(origin
>> +           (method url-fetch)
>> +           (uri (string-append
>> +                 "https://hackage.haskell.org/package/xmonad-"; version 
>> "/revision/1.cabal"))
>> +           (sha256
>> +            (base32
>> +             "0gdzsn2mv45i67wzmcjxyljr2w9fccc19n0i0f69mwvwcgi9v10j"))))))
>
> Could this instead be formulated as a patch, rather than a complete
> file overwrite?  A diff would help in understanding the rationale for
> the change.

It could, but since hackage provides this new Cabal file, it seemed
"cleanest" to not re-implement it as a patch.  If you prefer, i could do
one of two things:

* Add a comment explaining that the patch simply changed the library
  component's dependency on utf8-string from

     >=0.3 && <0.4

  to

     >=0.3 && <1.1

or,

* Add that as a "(substitute ...)" type patch.

My thinking was that the fact that this new Cabal file comes from
Hackage lends it a certain "credibility", whereas otherwise it might
look like i'm arbitrarily modifying the Cabal file to make it compile.
I admit that this was also the easier approach, it seemed to me.

I'll make it into whatever you prefer, but before messing around i
thought i'd ask.

Cheers, and thanks for all the comments,
p.